From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbbIFEII (ORCPT ); Sun, 6 Sep 2015 00:08:08 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:47248 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbbIFEH6 (ORCPT ); Sun, 6 Sep 2015 00:07:58 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 172.245.164.60 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <39d18724bbbf27e6f5e575b39750de51> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55EBBBFA.3020801@rock-chips.com> Date: Sun, 06 Sep 2015 12:07:22 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Heiko Stuebner , Thierry Reding , Jingoo Han , Inki Dae , joe@perches.com, Kukjin Kim , Mark Yao CC: Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087620-25586-1-git-send-email-ykk@rock-chips.com> <55E8E77C.4020305@samsung.com> In-Reply-To: <55E8E77C.4020305@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, 在 09/04/2015 08:36 AM, Krzysztof Kozlowski 写道: > On 01.09.2015 15:07, Yakir Yang wrote: > > Empty commit message. Please explain here why you want to add platform > device type support. > > Actually the title is confusing. You are not adding support for platform > device types but rather adding a field containing type of device. > > >> Signed-off-by: Yakir Yang >> --- >> Changes in v4: None >> Changes in v3: None >> Changes in v2: >> - Add GNU license v2 declared and samsung copyright >> >> drivers/gpu/drm/exynos/exynos_dp.c | 1 + >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + >> include/drm/bridge/analogix_dp.h | 16 ++++++++++++++++ >> 3 files changed, 18 insertions(+) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c >> index 6060d2c..40ef727 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp.c >> +++ b/drivers/gpu/drm/exynos/exynos_dp.c >> @@ -224,6 +224,7 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) >> dp->dev = dev; >> dp->drm_dev = drm_dev; >> >> + dp->plat_data.dev_type = EXYNOS_DP; >> dp->plat_data.power_on = exynos_dp_poweron; >> dp->plat_data.power_off = exynos_dp_poweroff; >> dp->plat_data.get_modes = exynos_dp_get_modes; >> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> index efea045..4934271 100644 >> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> @@ -293,6 +293,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, >> return ret; >> } >> >> + dp->plat_data.dev_type = RK3288_DP; >> dp->plat_data.attach = NULL; >> dp->plat_data.get_modes = NULL; >> dp->plat_data.power_on = rockchip_dp_poweron; >> diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h >> index 8b4ffad..7209a64 100644 >> --- a/include/drm/bridge/analogix_dp.h >> +++ b/include/drm/bridge/analogix_dp.h >> @@ -1,9 +1,25 @@ >> +/* >> + * Analogix Core DP (Display Port) interface driver. >> + * >> + * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the >> + * Free Software Foundation; either version 2 of the License, or (at your >> + * option) any later version. >> + */ > Two questions: > 1. Why this change is here? I would rather expect it at patch 3/16 when > you created this file... That is the usual time for adding copyrights. Yep, I should move this to 03/16. > 2. Does this file contains previous Samsung work? Hmm... I think this haven't contains the previous Samsung works, but I have the cover the head message from analogix_dp_core driver (include the copyright, but without ant author). Thanks - Yakir > Best regards, > Krzysztof > >> #ifndef _ANALOGIX_DP_H_ >> #define _ANALOGIX_DP_H_ >> >> #include >> >> +enum analogix_dp_devtype { >> + EXYNOS_DP, >> + RK3288_DP, >> +}; >> + >> struct analogix_dp_plat_data { >> + enum analogix_dp_devtype dev_type; >> struct drm_panel *panel; >> >> int (*power_on)(struct analogix_dp_plat_data *); >> > > >