From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbbIFOWn (ORCPT ); Sun, 6 Sep 2015 10:22:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38216 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbbIFOWg (ORCPT ); Sun, 6 Sep 2015 10:22:36 -0400 Subject: Re: [PATCH] kvm: compile process_smi_save_seg_64() only for x86_64 To: Alexander Kuleshov , Gleb Natapov References: <1441546541-20849-1-git-send-email-kuleshovmail@gmail.com> Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55EC4C28.6070705@redhat.com> Date: Sun, 6 Sep 2015 16:22:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1441546541-20849-1-git-send-email-kuleshovmail@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2015 15:35, Alexander Kuleshov wrote: > The process_smi_save_seg_64() function called only in the > process_smi_save_state_64() if the CONFIG_X86_64 is set. This > patch adds #ifdef CONFIG_X86_64 around process_smi_save_seg_64() > to prevent following warning message: > > arch/x86/kvm/x86.c:5946:13: warning: ‘process_smi_save_seg_64’ defined but not used [-Wunused-function] > static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n) > ^ > > Signed-off-by: Alexander Kuleshov > --- > arch/x86/kvm/x86.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 1e7e76e..a60bdbc 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -5943,6 +5943,7 @@ static void process_smi_save_seg_32(struct kvm_vcpu *vcpu, char *buf, int n) > put_smstate(u32, buf, offset, process_smi_get_segment_flags(&seg)); > } > > +#ifdef CONFIG_X86_64 > static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n) > { > struct kvm_segment seg; > @@ -5958,6 +5959,7 @@ static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n) > put_smstate(u32, buf, offset + 4, seg.limit); > put_smstate(u64, buf, offset + 8, seg.base); > } > +#endif > > static void process_smi_save_state_32(struct kvm_vcpu *vcpu, char *buf) > { > Applied, thanks. Paolo