From: Larry Finger <Larry.Finger@lwfinger.net>
To: Shraddha Barke <shraddha.6596@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy
Date: Sun, 6 Sep 2015 14:38:16 -0500 [thread overview]
Message-ID: <55EC9628.9010504@lwfinger.net> (raw)
In-Reply-To: <1441566274-3992-2-git-send-email-shraddha.6596@gmail.com>
On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> The patch replaces memcpy with ethr_addr_copy
>
> The changes were applied using the following coccinelle
> rule:
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The same comments apply as in patch 1/3. NACK.
Larry
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index 86f52ac..cf243fe 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
>
> eth_zero_addr(wrqu->ap_addr.sa_data);
> else
> - memcpy(wrqu->ap_addr.sa_data,
> - ieee->current_network.bssid, ETH_ALEN);
> + ether_addr_copy(wrqu->ap_addr.sa_data,
> + ieee->current_network.bssid);
>
> spin_unlock_irqrestore(&ieee->lock, flags);
>
>
next prev parent reply other threads:[~2015-09-06 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 19:04 [PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy Shraddha Barke
2015-09-06 19:04 ` [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy Shraddha Barke
2015-09-06 19:38 ` Larry Finger [this message]
2015-09-06 19:04 ` [PATCH 3/3] Staging: rtl8192u: r8192U_core.c: Replace memcpy with eth_addr_copy Shraddha Barke
2015-09-06 19:39 ` Larry Finger
2015-09-06 19:37 ` [PATCH 1/3] Staging: rtl8712: Replace memcpy by ether_addr_copy Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EC9628.9010504@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=mateusz.kulikowski@gmail.com \
--cc=shraddha.6596@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox