From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752834AbbIFTi0 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 6 Sep 2015 15:38:26 -0400
Received: from mail-ob0-f176.google.com ([209.85.214.176]:33664 "EHLO
	mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751695AbbIFTiT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 6 Sep 2015 15:38:19 -0400
Subject: Re: [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy
To: Shraddha Barke <shraddha.6596@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
        Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
        Julia Lawall <julia.lawall@lip6.fr>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        linux-kernel@vger.kernel.org
References: <1441566274-3992-1-git-send-email-shraddha.6596@gmail.com>
 <1441566274-3992-2-git-send-email-shraddha.6596@gmail.com>
From: Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <55EC9628.9010504@lwfinger.net>
Date: Sun, 6 Sep 2015 14:38:16 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1441566274-3992-2-git-send-email-shraddha.6596@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> The patch replaces memcpy with ethr_addr_copy
>
> The changes were applied using the following coccinelle
> rule:
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

The same comments apply as in patch 1/3. NACK.

Larry

>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index 86f52ac..cf243fe 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
>
>   		eth_zero_addr(wrqu->ap_addr.sa_data);
>   	else
> -		memcpy(wrqu->ap_addr.sa_data,
> -		       ieee->current_network.bssid, ETH_ALEN);
> +		ether_addr_copy(wrqu->ap_addr.sa_data,
> +				ieee->current_network.bssid);
>
>   	spin_unlock_irqrestore(&ieee->lock, flags);
>
>