From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753305AbbIFX4U (ORCPT ); Sun, 6 Sep 2015 19:56:20 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40734 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943AbbIFX4L (ORCPT ); Sun, 6 Sep 2015 19:56:11 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-f79c56d0000012ee-bf-55ecd298951a Content-transfer-encoding: 8BIT Subject: Re: [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support To: Yakir Yang , Heiko Stuebner , Thierry Reding , Jingoo Han , Inki Dae , joe@perches.com, Kukjin Kim , Mark Yao References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087620-25586-1-git-send-email-ykk@rock-chips.com> <55E8E77C.4020305@samsung.com> <55EBBBFA.3020801@rock-chips.com> Cc: Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <55ECD28B.40703@samsung.com> Date: Mon, 07 Sep 2015 08:55:55 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 In-reply-to: <55EBBBFA.3020801@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTURjHO+9t77TV27ydNLsMRAkyJYtDlElRvlFgRFJKVFNfVHQqm0r1 QU0d6nIpKaSrtJGl81LecDbNUiQx7xcmXbyUWOpWXlpWLDPnCPv2e87/93D+Hx4aF94knenI mHhOGiOOFlE2RNefDv2egkFjoFem3hG9fdJLImVvJ4aqjWoc5fS9ASg18wuJittXg9bpdApl /sjB0PD3OQrlGNUkWqyQ89DKRwOJemc1AN0ezyVQmamQh+6OTxLIMO2NciYNOOqfyqZQT6qR h2on9SQa0t2j0OLECo4K+low1Jj/EkO5d6oIVDc/QyH583Ye+rG0RKGBh+M89M68CfWm5PH8 drKVRZWATU/LptjPOgPGDt1SYuzy5xGCfaYa5bGaUhPF1pZnUax2aYJkx292YGxdSTKrTPtK saZyPc4uq14Q7K36csBq9UX4GWGwzaEwLjoykZPu9b1iEzHySoPHDbpeHdAZyBTQ5aQANA0Z H7hQ46cA/FV0hP1jTykFsKGFzCMAf98owy2BgNkCf+aNERYfZ3bA9sEoK7rD/HyJVTcB+KlD Ayy6HRMMJzOqeRa2ZzIx2DTib5VaANR3fsAsA84UUvBXxcjaBsXsg3WlJZT1Mw+YNd9NWJhg 3GCD4f2a48BcgK97vqw5fMYTNgx0gFzAqP7rp1rvp1rv9wDg5cCBSwiNk4WES7w9ZWKJLCEm 3DM0VlILrCdiagQPXx1sAwwNRBsFXkpjoJAUJ8quSdoApHGRvcCnfvVJECa+dp2Txl6WJkRz sjbgQhMiJ8F93dw5IRMujueiOC6Ok/5LMZrvnALU1RW6/YGukbbFLu5j8tczPupm7db4i6PV h89OB50UJStNCvdhW0XUhu7tSUealAfy5dtck2rEVwuLtdOdC0fT1DPf4qcGqFLfgICixKpU mb8dMG/b2NPcVLCiPb9Z03pal53o8jjk+JFY/ql+edDhXUkZJeZjpR6PzZdmT7g5eIsIWYTY ezculYn/AmL+jQoeAwAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.09.2015 13:07, Yakir Yang wrote: > Hi Krzysztof, > > 在 09/04/2015 08:36 AM, Krzysztof Kozlowski 写道: >> On 01.09.2015 15:07, Yakir Yang wrote: >> >> Empty commit message. Please explain here why you want to add platform >> device type support. >> >> Actually the title is confusing. You are not adding support for platform >> device types but rather adding a field containing type of device. >> >> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v4: None >>> Changes in v3: None >>> Changes in v2: >>> - Add GNU license v2 declared and samsung copyright >>> >>> drivers/gpu/drm/exynos/exynos_dp.c | 1 + >>> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + >>> include/drm/bridge/analogix_dp.h | 16 ++++++++++++++++ >>> 3 files changed, 18 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/exynos/exynos_dp.c >>> b/drivers/gpu/drm/exynos/exynos_dp.c >>> index 6060d2c..40ef727 100644 >>> --- a/drivers/gpu/drm/exynos/exynos_dp.c >>> +++ b/drivers/gpu/drm/exynos/exynos_dp.c >>> @@ -224,6 +224,7 @@ static int exynos_dp_bind(struct device *dev, >>> struct device *master, void *data) >>> dp->dev = dev; >>> dp->drm_dev = drm_dev; >>> + dp->plat_data.dev_type = EXYNOS_DP; >>> dp->plat_data.power_on = exynos_dp_poweron; >>> dp->plat_data.power_off = exynos_dp_poweroff; >>> dp->plat_data.get_modes = exynos_dp_get_modes; >>> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >>> b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >>> index efea045..4934271 100644 >>> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >>> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >>> @@ -293,6 +293,7 @@ static int rockchip_dp_bind(struct device *dev, >>> struct device *master, >>> return ret; >>> } >>> + dp->plat_data.dev_type = RK3288_DP; >>> dp->plat_data.attach = NULL; >>> dp->plat_data.get_modes = NULL; >>> dp->plat_data.power_on = rockchip_dp_poweron; >>> diff --git a/include/drm/bridge/analogix_dp.h >>> b/include/drm/bridge/analogix_dp.h >>> index 8b4ffad..7209a64 100644 >>> --- a/include/drm/bridge/analogix_dp.h >>> +++ b/include/drm/bridge/analogix_dp.h >>> @@ -1,9 +1,25 @@ >>> +/* >>> + * Analogix Core DP (Display Port) interface driver. >>> + * >>> + * Copyright (C) 2012 Samsung Electronics Co., Ltd. >>> + * >>> + * This program is free software; you can redistribute it and/or >>> modify it >>> + * under the terms of the GNU General Public License as published by >>> the >>> + * Free Software Foundation; either version 2 of the License, or (at >>> your >>> + * option) any later version. >>> + */ >> Two questions: >> 1. Why this change is here? I would rather expect it at patch 3/16 when >> you created this file... That is the usual time for adding copyrights. > > Yep, I should move this to 03/16. > >> 2. Does this file contains previous Samsung work? > > Hmm... I think this haven't contains the previous Samsung works, > but I have the cover the head message from analogix_dp_core driver > (include the copyright, but without ant author). If it does not contain Samsung's work then don't mention its copyrights. Best regards, Krzysztof > > Thanks > - Yakir > >> Best regards, >> Krzysztof >> >>> #ifndef _ANALOGIX_DP_H_ >>> #define _ANALOGIX_DP_H_ >>> #include >>> +enum analogix_dp_devtype { >>> + EXYNOS_DP, >>> + RK3288_DP, >>> +}; >>> + >>> struct analogix_dp_plat_data { >>> + enum analogix_dp_devtype dev_type; >>> struct drm_panel *panel; >>> int (*power_on)(struct analogix_dp_plat_data *); >>> >> >> >> > > >