From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753392AbbIGBuD (ORCPT ); Sun, 6 Sep 2015 21:50:03 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:42131 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbbIGBuA (ORCPT ); Sun, 6 Sep 2015 21:50:00 -0400 Subject: Re: [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning To: Geert Uytterhoeven , Guennadi Liakhovetski , Mauro Carvalho Chehab References: <1441534129-24413-1-git-send-email-geert@linux-m68k.org> CC: , From: Josh Wu Message-ID: <55ECED29.5000600@atmel.com> Date: Mon, 7 Sep 2015 09:49:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441534129-24413-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Geert Uytterhoeven Thanks for the patch. On 9/6/2015 6:08 PM, Geert Uytterhoeven wrote: > If CONFIG_PM=n: > > drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used > drivers/media/platform/soc_camera/atmel-isi.c:1054: warning: ‘atmel_isi_runtime_resume’ defined but not used > > Protect the unused functions by #ifdef CONFIG_PM to fix this. > > Signed-off-by: Geert Uytterhoeven Acked-by: Josh Wu Best Regards, Josh Wu > --- > Resend with correct suject > --- > drivers/media/platform/soc_camera/atmel-isi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c > index 90701726a06a2e5c..ccf30ccbe389233f 100644 > --- a/drivers/media/platform/soc_camera/atmel-isi.c > +++ b/drivers/media/platform/soc_camera/atmel-isi.c > @@ -1040,6 +1040,7 @@ err_alloc_ctx: > return ret; > } > > +#ifdef CONFIG_PM > static int atmel_isi_runtime_suspend(struct device *dev) > { > struct soc_camera_host *soc_host = to_soc_camera_host(dev); > @@ -1058,6 +1059,7 @@ static int atmel_isi_runtime_resume(struct device *dev) > > return clk_prepare_enable(isi->pclk); > } > +#endif /* CONFIG_PM */ > > static const struct dev_pm_ops atmel_isi_dev_pm_ops = { > SET_RUNTIME_PM_OPS(atmel_isi_runtime_suspend,