From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753431AbbIGHtI (ORCPT ); Mon, 7 Sep 2015 03:49:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:50050 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbbIGHtD (ORCPT ); Mon, 7 Sep 2015 03:49:03 -0400 X-AuditID: cbfec7f5-f794b6d000001495-b3-55ed416dbd8d Message-id: <55ED416D.2000408@samsung.com> Date: Mon, 07 Sep 2015 09:49:01 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Muhammad Falak R Wani Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: leds-ot200: Use devm_led_classdev_register References: <1441463007-15638-1-git-send-email-falakreyaz@gmail.com> In-reply-to: <1441463007-15638-1-git-send-email-falakreyaz@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t/xK7p5jm9DDa7rWRzdOZHJYvfD86wW l3fNYbPY+mYdo8XuXU9ZHVg9ds66y+6xZ/4PVo/Pm+QCmKO4bFJSczLLUov07RK4Mm48X8te sJCl4t27p+wNjIeYuxg5OSQETCQuTV3PBGGLSVy4t56ti5GLQ0hgKaPEpqN7WCCcZ4wS05sO sINU8QpoSXxb+hPMZhFQlWi7OJcNxGYTMJT4+eI12CRRgQiJP6f3sULUC0r8mHwPaBAHh4iA gcTnT4EgYWaBRkaJ3lYREFtYwFViafNesHIhAReJ5Ss2gpVzAsU/fHWFKLeWWDlpGyOELS+x ec1b5gmMArOQLJiFpGwWkrIFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MUIC9+sOxqXH rA4xCnAwKvHw3uh6EyrEmlhWXJl7iFGCg1lJhNdkC1CINyWxsiq1KD++qDQntfgQozQHi5I4 78xd70OEBNITS1KzU1MLUotgskwcnFINjNLchqWS/Hc2NBS9k9jm9Zf14DN+n8U/7A63Fyhl iN9auPftHTnv/vzJ3BLfgn4z2mWtleVLOL3uUw1jqajk3vxTOipX90nfrEy98NZ0pZbCBJ/L KV760SKGByt5Wk7pp612Tru4vnzytLaY1W9rDk6s/uKfcrzjOO9518gt6TeSV+y/e3btUiWW 4oxEQy3mouJEAPiyZF1YAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2015 04:23 PM, Muhammad Falak R Wani wrote: > Use resource-managed function devm_led_classdev_register > instead of led_classdev_register to make the error path simpler. > The goto is replaced with direct return, unneeded label err is > dropped. Also, remove redundant ot200_led_remove. > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/leds/leds-ot200.c | 21 ++------------------- > 1 file changed, 2 insertions(+), 19 deletions(-) Merged, thanks. -- Best Regards, Jacek Anaszewski