From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754142AbbIGJ1D (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Sep 2015 05:27:03 -0400
Received: from lists.s-osg.org ([54.187.51.154]:34581 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751018AbbIGJ07 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Sep 2015 05:26:59 -0400
Subject: Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip
 devices/busses
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
        linux-rockchip@lists.infradead.org
References: <1441570566-14001-1-git-send-email-sjoerd.simons@collabora.co.uk>
 <1441570566-14001-2-git-send-email-sjoerd.simons@collabora.co.uk>
From: Javier Martinez Canillas <javier@osg.samsung.com>
X-Enigmail-Draft-Status: N1110
Cc: linux-arm-kernel@lists.infradead.org, Heiko Stuebner <heiko@sntech.de>,
        Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Thierry Reding <treding@nvidia.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        linux-kernel@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
        Olof Johansson <olof@lixom.net>, Ray Jui <rjui@broadcom.com>,
        Stephen Warren <swarren@nvidia.com>
Message-ID: <55ED585B.9030009@osg.samsung.com>
Date: Mon, 7 Sep 2015 11:26:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <1441570566-14001-2-git-send-email-sjoerd.simons@collabora.co.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Sjoerd,

On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> Enable Rockchip I2C, SPI, PWM, thermal drivers.
> 
> Builtin are:
>  * I2C as it often controls the pmic.

Having I2C as a module will cause more probe deferrals due missing
regulators and slow down the boot but it should not cause issues.
Or am I missing something?

In fact, I think even the PMIC could be built as a module.

But I don't have a strong opinion on this so patch looks good:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America