From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>,
gleb@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: cornelia.huck@de.ibm.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH V3 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister
Date: Mon, 7 Sep 2015 12:33:51 +0200 [thread overview]
Message-ID: <55ED680F.4080100@redhat.com> (raw)
In-Reply-To: <1440493548-2971-1-git-send-email-jasowang@redhat.com>
On 25/08/2015 11:05, Jason Wang wrote:
> All fields of kvm_io_range were initialized or copied explicitly
> afterwards. So switch to use kmalloc().
>
> Cc: Gleb Natapov <gleb@kernel.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> virt/kvm/kvm_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 8b8a444..0d79fe8 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -3248,7 +3248,7 @@ int kvm_io_bus_register_dev(struct kvm *kvm, enum kvm_bus bus_idx, gpa_t addr,
> if (bus->dev_count - bus->ioeventfd_count > NR_IOBUS_DEVS - 1)
> return -ENOSPC;
>
> - new_bus = kzalloc(sizeof(*bus) + ((bus->dev_count + 1) *
> + new_bus = kmalloc(sizeof(*bus) + ((bus->dev_count + 1) *
> sizeof(struct kvm_io_range)), GFP_KERNEL);
> if (!new_bus)
> return -ENOMEM;
> @@ -3280,7 +3280,7 @@ int kvm_io_bus_unregister_dev(struct kvm *kvm, enum kvm_bus bus_idx,
> if (r)
> return r;
>
> - new_bus = kzalloc(sizeof(*bus) + ((bus->dev_count - 1) *
> + new_bus = kmalloc(sizeof(*bus) + ((bus->dev_count - 1) *
> sizeof(struct kvm_io_range)), GFP_KERNEL);
> if (!new_bus)
> return -ENOMEM;
>
Applied this patch for 4.4.
Paolo
prev parent reply other threads:[~2015-09-07 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 9:05 [PATCH V3 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister Jason Wang
2015-08-25 9:05 ` [PATCH V3 2/3] kvm: don't register wildcard MMIO EVENTFD on two buses Jason Wang
2015-08-25 10:24 ` Cornelia Huck
2015-08-25 11:37 ` Michael S. Tsirkin
2015-08-25 11:51 ` Michael S. Tsirkin
2015-08-26 5:10 ` Jason Wang
2015-08-31 3:12 ` Jason Wang
2015-08-31 7:29 ` Michael S. Tsirkin
2015-08-31 8:03 ` Jason Wang
2015-08-31 11:33 ` Michael S. Tsirkin
2015-09-01 3:33 ` Jason Wang
2015-09-01 4:31 ` Michael S. Tsirkin
2015-09-01 4:47 ` Jason Wang
2015-09-01 6:54 ` Michael S. Tsirkin
2015-09-01 8:22 ` Jason Wang
2015-09-01 8:32 ` Michael S. Tsirkin
2015-08-25 9:05 ` [PATCH V3 3/3] kvm: add tracepoint for fast mmio Jason Wang
2015-08-25 11:36 ` Michael S. Tsirkin
2015-09-07 10:33 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED680F.4080100@redhat.com \
--to=pbonzini@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).