From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbbIGKgO (ORCPT ); Mon, 7 Sep 2015 06:36:14 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33841 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbbIGKgK (ORCPT ); Mon, 7 Sep 2015 06:36:10 -0400 Subject: Re: [PATCH 0/5] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller To: linux-mmc@vger.kernel.org References: <1441380741-13115-1-git-send-email-vaibhav.hiremath@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kliu5@marvell.com, ulf.hansson@linaro.org From: Vaibhav Hiremath Message-ID: <55ED6895.7000404@linaro.org> Date: Mon, 7 Sep 2015 16:06:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441380741-13115-1-git-send-email-vaibhav.hiremath@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 04 September 2015 09:02 PM, Vaibhav Hiremath wrote: > PXA1928 SDHCI controller has few differences, for example, > > PXAxxx PXA1928 > ====== ======= > SDCLK_DELAY field 0x10A 0x114 > SDCLK_DELAY mask 0x1F 0x3FF > SDCLK_DELAY shift 9 8 > SDCLK_SEL shift 8 2 (SEL1) > > So this patch series introduces new compatible device_id > (marvell,pxav3-1928-sdhci), and makes use of .data for handling > such differences. > > The series also adds support like, > > - independent ->set_clock() api, as we need to enable internal clock gate > and TX clock > - pinctrl configuration based on bus speed. > - introduce new quirk SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER > SD_BUS_POWER & SD_BUS_VLT bit-fields are used internally to gate the > clocks, so it is important to configure them as part of ->set_power() > More detailed description is written into commit log. > - Enable SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for PXA1928 device_id > Please ignore this series, as one residual change (rather typo error). Mistakenly while checking in the code, instead of 1928 compatible property it was 988. I will submit the new series shortly. Thanks, Vaibhav > > Testing: > I have done basic testing on both eMMC and SD card on PXA1928 based > platform. > > Note: I tried to made sure that I do not break any other platform, which > used sdhci, except HS200 configuration. > Unfortunately I do not have access to any other datasheets, where I can > cross check the details on HS200 bit-fields. Probably someone who has > access can confirm [PATCH 4/5], whether it impacts other platforms. > > Kevin Liu (1): > mmc: sdhci-pxav3: Fix HS200 mode support > > Vaibhav Hiremath (4): > mmc: sdhci-pxav3: Enable pxa1928 device support > mmc: sdhci-pxav3: Add platform specific set_clock ops > mmc: sdhci-pxav3: Add pinctl setting according to bus clock > mmc: sdhci: add new quirk for setting BUS_POWER & BUS_VLT fields > > drivers/mmc/host/sdhci-pltfm.c | 3 + > drivers/mmc/host/sdhci-pxav3.c | 168 ++++++++++++++++++++++++++++++++++++++--- > drivers/mmc/host/sdhci.c | 3 +- > drivers/mmc/host/sdhci.h | 2 + > 4 files changed, 163 insertions(+), 13 deletions(-) >