From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbbIGKiR (ORCPT ); Mon, 7 Sep 2015 06:38:17 -0400 Received: from lists.s-osg.org ([54.187.51.154]:34637 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbbIGKiQ (ORCPT ); Mon, 7 Sep 2015 06:38:16 -0400 Subject: Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses To: Sjoerd Simons , linux-rockchip@lists.infradead.org References: <1441570566-14001-1-git-send-email-sjoerd.simons@collabora.co.uk> <1441570566-14001-2-git-send-email-sjoerd.simons@collabora.co.uk> <55ED585B.9030009@osg.samsung.com> <1441621467.8778.26.camel@collabora.co.uk> Cc: linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Kukjin Kim , Krzysztof Kozlowski , Thierry Reding , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Russell King , Alexandre Belloni , Arnd Bergmann , Lee Jones , Olof Johansson , Ray Jui , Stephen Warren From: Javier Martinez Canillas Message-ID: <55ED6910.8010202@osg.samsung.com> Date: Mon, 7 Sep 2015 12:38:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1441621467.8778.26.camel@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sjoerd, On 09/07/2015 12:24 PM, Sjoerd Simons wrote: > On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote: >> Hello Sjoerd, >> >> On 09/06/2015 10:16 PM, Sjoerd Simons wrote: >>> Enable Rockchip I2C, SPI, PWM, thermal drivers. >>> >>> Builtin are: >>> * I2C as it often controls the pmic. >> >> Having I2C as a module will cause more probe deferrals due missing >> regulators and slow down the boot but it should not cause issues. >> Or am I missing something? >> >> In fact, I think even the PMIC could be built as a module. > > It could in principle. However as a lot of other drivers do need the > regulators provided by the pmic, they'll be deferred until that driver > is loaded. So e.g. with the i2c/pmic drivers as a module you cannot > boot to an NFS rootfs without using an initramfs. > Right, not needing an initramfs is certainly a good reason. If you could add something like that in the commit message of patches 1/4 and 2/4 that would be great. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America