From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751287AbbIGK4N (ORCPT ); Mon, 7 Sep 2015 06:56:13 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:33183 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbbIGK4K (ORCPT ); Mon, 7 Sep 2015 06:56:10 -0400 X-Greylist: delayed 403 seconds by postgrey-1.27 at vger.kernel.org; Mon, 07 Sep 2015 06:56:08 EDT X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses To: Sjoerd Simons , Javier Martinez Canillas , linux-rockchip@lists.infradead.org References: <1441570566-14001-1-git-send-email-sjoerd.simons@collabora.co.uk> <1441570566-14001-2-git-send-email-sjoerd.simons@collabora.co.uk> <55ED585B.9030009@osg.samsung.com> <1441621467.8778.26.camel@collabora.co.uk> Cc: Krzysztof Kozlowski , Russell King , Heiko Stuebner , Geert Uytterhoeven , Ray Jui , linux-kernel@vger.kernel.org, Arnd Bergmann , Kukjin Kim , Alexandre Belloni , Olof Johansson , Stephen Warren , Thierry Reding , Lee Jones , linux-arm-kernel@lists.infradead.org From: Andy Yan Message-ID: <55ED6D35.6060704@rock-chips.com> Date: Mon, 7 Sep 2015 18:55:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441621467.8778.26.camel@collabora.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi There are also many other devices like display and mmc and even the cpu(if the cpu want run a high frequency when boot up)need to get power supply from PMIC, so it is better to load PMIC as early as possible.Built-in is a better choice. On 2015年09月07日 18:24, Sjoerd Simons wrote: > On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote: >> Hello Sjoerd, >> >> On 09/06/2015 10:16 PM, Sjoerd Simons wrote: >>> Enable Rockchip I2C, SPI, PWM, thermal drivers. >>> >>> Builtin are: >>> * I2C as it often controls the pmic. >> Having I2C as a module will cause more probe deferrals due missing >> regulators and slow down the boot but it should not cause issues. >> Or am I missing something? >> >> In fact, I think even the PMIC could be built as a module. > It could in principle. However as a lot of other drivers do need the > regulators provided by the pmic, they'll be deferred until that driver > is loaded. So e.g. with the i2c/pmic drivers as a module you cannot > boot to an NFS rootfs without using an initramfs. > >> But I don't have a strong opinion on this so patch looks good: >> >> Reviewed-by: Javier Martinez Canillas >> >> Best regards,