From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751567AbbIGL2F (ORCPT ); Mon, 7 Sep 2015 07:28:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50848 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbbIGL1w (ORCPT ); Mon, 7 Sep 2015 07:27:52 -0400 Subject: Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() To: Xiao Guangrong References: <1440132611-26052-1-git-send-email-guangrong.xiao@linux.intel.com> <1440132611-26052-9-git-send-email-guangrong.xiao@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55ED74B3.3070202@redhat.com> Date: Mon, 7 Sep 2015 13:27:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1440132611-26052-9-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/08/2015 06:50, Xiao Guangrong wrote: > > +static void set_clear_2nd_exec_ctrl(u32 ctrls, bool set) > +{ > + u32 exec_ctrl = vmcs_read32(SECONDARY_VM_EXEC_CONTROL); > + > + if (set) > + exec_ctrl |= ctrls; > + else > + exec_ctrl &= ~ctrls; > + > + vmcs_write32(SECONDARY_VM_EXEC_CONTROL, exec_ctrl); > +} The second argument is always true. Do you have any plans for it? Should we instead add functions like vmcs_or32 and vmcs_clear32? Paolo