* [PATCH v2 0/2] leds: leds-ipaq-micro: Use resource managed functions and fix coding style. @ 2015-09-07 14:13 Muhammad Falak R Wani 2015-09-07 14:13 ` [PATCH v2 1/2] leds: leds-ipaq-micro: Use devm_led_classdev_register Muhammad Falak R Wani 2015-09-07 14:13 ` [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues Muhammad Falak R Wani 0 siblings, 2 replies; 5+ messages in thread From: Muhammad Falak R Wani @ 2015-09-07 14:13 UTC (permalink / raw) To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds, linux-kernel Cc: Muhammad Falak R Wani Hi, Based on the suggestion from Jaeck, the orginal patch is split into two, one patch fixes the coding style issues, and the other uses resource managed function, devm_led_classdev_register. Muhammad Falak R Wani (2): leds: leds-ipaq-micro: Use devm_led_classdev_register leds: leds-ipaq-micro: Fix coding style issues drivers/leds/leds-ipaq-micro.c | 47 ++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 27 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] leds: leds-ipaq-micro: Use devm_led_classdev_register 2015-09-07 14:13 [PATCH v2 0/2] leds: leds-ipaq-micro: Use resource managed functions and fix coding style Muhammad Falak R Wani @ 2015-09-07 14:13 ` Muhammad Falak R Wani 2015-09-07 14:58 ` Jacek Anaszewski 2015-09-07 14:13 ` [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues Muhammad Falak R Wani 1 sibling, 1 reply; 5+ messages in thread From: Muhammad Falak R Wani @ 2015-09-07 14:13 UTC (permalink / raw) To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds, linux-kernel Cc: Muhammad Falak R Wani Use of resource-managed function devm_led_classdev_register instead of led_classdev_register is preferred, consequently remove redundant function micro_leds_remove. Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> --- drivers/leds/leds-ipaq-micro.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/leds/leds-ipaq-micro.c b/drivers/leds/leds-ipaq-micro.c index 3776f51..1206215 100644 --- a/drivers/leds/leds-ipaq-micro.c +++ b/drivers/leds/leds-ipaq-micro.c @@ -111,7 +111,7 @@ static int micro_leds_probe(struct platform_device *pdev) { int ret; - ret = led_classdev_register(&pdev->dev, µ_led); + ret = devm_led_classdev_register(&pdev->dev, µ_led); if (ret) { dev_err(&pdev->dev, "registering led failed: %d\n", ret); return ret; @@ -121,18 +121,11 @@ static int micro_leds_probe(struct platform_device *pdev) return 0; } -static int micro_leds_remove(struct platform_device *pdev) -{ - led_classdev_unregister(µ_led); - return 0; -} - static struct platform_driver micro_leds_device_driver = { .driver = { .name = "ipaq-micro-leds", }, .probe = micro_leds_probe, - .remove = micro_leds_remove, }; module_platform_driver(micro_leds_device_driver); -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] leds: leds-ipaq-micro: Use devm_led_classdev_register 2015-09-07 14:13 ` [PATCH v2 1/2] leds: leds-ipaq-micro: Use devm_led_classdev_register Muhammad Falak R Wani @ 2015-09-07 14:58 ` Jacek Anaszewski 0 siblings, 0 replies; 5+ messages in thread From: Jacek Anaszewski @ 2015-09-07 14:58 UTC (permalink / raw) To: Muhammad Falak R Wani; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel On 09/07/2015 04:13 PM, Muhammad Falak R Wani wrote: > Use of resource-managed function devm_led_classdev_register > instead of led_classdev_register is preferred, consequently > remove redundant function micro_leds_remove. > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> > --- > drivers/leds/leds-ipaq-micro.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) Merged, thanks. -- Best Regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues 2015-09-07 14:13 [PATCH v2 0/2] leds: leds-ipaq-micro: Use resource managed functions and fix coding style Muhammad Falak R Wani 2015-09-07 14:13 ` [PATCH v2 1/2] leds: leds-ipaq-micro: Use devm_led_classdev_register Muhammad Falak R Wani @ 2015-09-07 14:13 ` Muhammad Falak R Wani 2015-09-07 14:54 ` Jacek Anaszewski 1 sibling, 1 reply; 5+ messages in thread From: Muhammad Falak R Wani @ 2015-09-07 14:13 UTC (permalink / raw) To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds, linux-kernel Cc: Muhammad Falak R Wani Spaces at the starting of a line are removed, indentation using tab, instead of space. Also, warnings related to line width of more than 80 characters is also taken care of. Two warnings have been left alone to aid better readability. Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> --- drivers/leds/leds-ipaq-micro.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/leds/leds-ipaq-micro.c b/drivers/leds/leds-ipaq-micro.c index 1206215..86716ea 100644 --- a/drivers/leds/leds-ipaq-micro.c +++ b/drivers/leds/leds-ipaq-micro.c @@ -16,9 +16,9 @@ #define LED_YELLOW 0x00 #define LED_GREEN 0x01 -#define LED_EN (1 << 4) /* LED ON/OFF 0:off, 1:on */ -#define LED_AUTOSTOP (1 << 5) /* LED ON/OFF auto stop set 0:disable, 1:enable */ -#define LED_ALWAYS (1 << 6) /* LED Interrupt Mask 0:No mask, 1:mask */ +#define LED_EN (1 << 4) /* LED ON/OFF 0:off, 1:on */ +#define LED_AUTOSTOP (1 << 5) /* LED ON/OFF auto stop set 0:disable,1:enable*/ +#define LED_ALWAYS (1 << 6) /* LED Interrupt Mask 0:No mask, 1:mask */ static void micro_leds_brightness_set(struct led_classdev *led_cdev, enum led_brightness value) @@ -27,14 +27,14 @@ static void micro_leds_brightness_set(struct led_classdev *led_cdev, /* * In this message: * Byte 0 = LED color: 0 = yellow, 1 = green - * yellow LED is always ~30 blinks per minute + * yellow LED is always ~30 blinks per minute * Byte 1 = duration (flags?) appears to be ignored * Byte 2 = green ontime in 1/10 sec (deciseconds) - * 1 = 1/10 second - * 0 = 256/10 second + * 1 = 1/10 second + * 0 = 256/10 second * Byte 3 = green offtime in 1/10 sec (deciseconds) - * 1 = 1/10 second - * 0 = 256/10 seconds + * 1 = 1/10 second + * 0 = 256/10 seconds */ struct ipaq_micro_msg msg = { .id = MSG_NOTIFY_LED, @@ -64,14 +64,14 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev, /* * In this message: * Byte 0 = LED color: 0 = yellow, 1 = green - * yellow LED is always ~30 blinks per minute + * yellow LED is always ~30 blinks per minute * Byte 1 = duration (flags?) appears to be ignored * Byte 2 = green ontime in 1/10 sec (deciseconds) - * 1 = 1/10 second - * 0 = 256/10 second + * 1 = 1/10 second + * 0 = 256/10 second * Byte 3 = green offtime in 1/10 sec (deciseconds) - * 1 = 1/10 second - * 0 = 256/10 seconds + * 1 = 1/10 second + * 0 = 256/10 seconds */ struct ipaq_micro_msg msg = { .id = MSG_NOTIFY_LED, @@ -79,14 +79,14 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev, }; msg.tx_data[0] = LED_GREEN; - if (*delay_on > IPAQ_LED_MAX_DUTY || + if (*delay_on > IPAQ_LED_MAX_DUTY || *delay_off > IPAQ_LED_MAX_DUTY) - return -EINVAL; + return -EINVAL; - if (*delay_on == 0 && *delay_off == 0) { - *delay_on = 100; - *delay_off = 100; - } + if (*delay_on == 0 && *delay_off == 0) { + *delay_on = 100; + *delay_off = 100; + } msg.tx_data[1] = 0; if (*delay_on >= IPAQ_LED_MAX_DUTY) -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues 2015-09-07 14:13 ` [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues Muhammad Falak R Wani @ 2015-09-07 14:54 ` Jacek Anaszewski 0 siblings, 0 replies; 5+ messages in thread From: Jacek Anaszewski @ 2015-09-07 14:54 UTC (permalink / raw) To: Muhammad Falak R Wani; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel Hi Muhammad, On 09/07/2015 04:13 PM, Muhammad Falak R Wani wrote: > Spaces at the starting of a line are removed, indentation > using tab, instead of space. Also, warnings related to > line width of more than 80 characters is also taken care of. > Two warnings have been left alone to aid better readability. > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> > --- > drivers/leds/leds-ipaq-micro.c | 38 +++++++++++++++++++------------------- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/leds/leds-ipaq-micro.c b/drivers/leds/leds-ipaq-micro.c > index 1206215..86716ea 100644 > --- a/drivers/leds/leds-ipaq-micro.c > +++ b/drivers/leds/leds-ipaq-micro.c > @@ -16,9 +16,9 @@ > #define LED_YELLOW 0x00 > #define LED_GREEN 0x01 > > -#define LED_EN (1 << 4) /* LED ON/OFF 0:off, 1:on */ > -#define LED_AUTOSTOP (1 << 5) /* LED ON/OFF auto stop set 0:disable, 1:enable */ > -#define LED_ALWAYS (1 << 6) /* LED Interrupt Mask 0:No mask, 1:mask */ > +#define LED_EN (1 << 4) /* LED ON/OFF 0:off, 1:on */ > +#define LED_AUTOSTOP (1 << 5) /* LED ON/OFF auto stop set 0:disable,1:enable*/ > +#define LED_ALWAYS (1 << 6) /* LED Interrupt Mask 0:No mask, 1:mask */ Please keep comments ending in the same column. > > static void micro_leds_brightness_set(struct led_classdev *led_cdev, > enum led_brightness value) > @@ -27,14 +27,14 @@ static void micro_leds_brightness_set(struct led_classdev *led_cdev, > /* > * In this message: > * Byte 0 = LED color: 0 = yellow, 1 = green > - * yellow LED is always ~30 blinks per minute > + * yellow LED is always ~30 blinks per minute > * Byte 1 = duration (flags?) appears to be ignored > * Byte 2 = green ontime in 1/10 sec (deciseconds) > - * 1 = 1/10 second > - * 0 = 256/10 second > + * 1 = 1/10 second > + * 0 = 256/10 second > * Byte 3 = green offtime in 1/10 sec (deciseconds) > - * 1 = 1/10 second > - * 0 = 256/10 seconds > + * 1 = 1/10 second > + * 0 = 256/10 seconds > */ > struct ipaq_micro_msg msg = { > .id = MSG_NOTIFY_LED, > @@ -64,14 +64,14 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev, > /* > * In this message: > * Byte 0 = LED color: 0 = yellow, 1 = green > - * yellow LED is always ~30 blinks per minute > + * yellow LED is always ~30 blinks per minute > * Byte 1 = duration (flags?) appears to be ignored > * Byte 2 = green ontime in 1/10 sec (deciseconds) > - * 1 = 1/10 second > - * 0 = 256/10 second > + * 1 = 1/10 second > + * 0 = 256/10 second > * Byte 3 = green offtime in 1/10 sec (deciseconds) > - * 1 = 1/10 second > - * 0 = 256/10 seconds > + * 1 = 1/10 second > + * 0 = 256/10 seconds > */ This looks worse after applying the patch. Why actually did you change it? AFAICS checkpatch.pl doesn't complain here. > struct ipaq_micro_msg msg = { > .id = MSG_NOTIFY_LED, > @@ -79,14 +79,14 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev, > }; > > msg.tx_data[0] = LED_GREEN; > - if (*delay_on > IPAQ_LED_MAX_DUTY || > + if (*delay_on > IPAQ_LED_MAX_DUTY || > *delay_off > IPAQ_LED_MAX_DUTY) > - return -EINVAL; > + return -EINVAL; > > - if (*delay_on == 0 && *delay_off == 0) { > - *delay_on = 100; > - *delay_off = 100; > - } > + if (*delay_on == 0 && *delay_off == 0) { > + *delay_on = 100; > + *delay_off = 100; > + } > > msg.tx_data[1] = 0; > if (*delay_on >= IPAQ_LED_MAX_DUTY) > -- Best Regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-07 14:59 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-09-07 14:13 [PATCH v2 0/2] leds: leds-ipaq-micro: Use resource managed functions and fix coding style Muhammad Falak R Wani 2015-09-07 14:13 ` [PATCH v2 1/2] leds: leds-ipaq-micro: Use devm_led_classdev_register Muhammad Falak R Wani 2015-09-07 14:58 ` Jacek Anaszewski 2015-09-07 14:13 ` [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues Muhammad Falak R Wani 2015-09-07 14:54 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox