From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbbIGSUG (ORCPT ); Mon, 7 Sep 2015 14:20:06 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:33716 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935AbbIGSUD (ORCPT ); Mon, 7 Sep 2015 14:20:03 -0400 Subject: Re: [PATCH] stmmac: fix check for phydev being open To: Alexey Brodkin , netdev@vger.kernel.org References: <1441649709-12325-1-git-send-email-abrodkin@synopsys.com> Cc: Giuseppe Cavallaro , arc-linux-dev@synopsys.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Miller From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55EDD54E.7030205@cogentembedded.com> Date: Mon, 7 Sep 2015 21:19:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1441649709-12325-1-git-send-email-abrodkin@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 09/07/2015 09:15 PM, Alexey Brodkin wrote: > Current implementation via IS_ERR(phydev) may make no sense because > of_phy_attach() returns NULL on failure instead of error value. > Still for checking result of phy_connect() IS_ERR() is useful. > So adding explicit check for NULL. > Cc: Giuseppe Cavallaro > Cc: arc-linux-dev@synopsys.com > Cc: linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org > Cc: David Miller > Signed-off-by: Alexey Brodkin > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 864b476..ad2ce3e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev) > interface); > } > > - if (IS_ERR(phydev)) { > + if (!phydev || IS_ERR(phydev)) { There's IS_ERR_OR_NULL(). WBR, Sergei