From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163AbbIGUGY (ORCPT ); Mon, 7 Sep 2015 16:06:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbbIGUGW (ORCPT ); Mon, 7 Sep 2015 16:06:22 -0400 Subject: Re: [PATCH] kvm: irqchip: fix memory leak To: Sudip Mukherjee , Gleb Natapov References: <1441177433-20225-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Paolo Bonzini Message-ID: <55EDEE3A.1030700@redhat.com> Date: Mon, 7 Sep 2015 22:06:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1441177433-20225-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2015 09:03, Sudip Mukherjee wrote: > We were taking the exit path after checking ue->flags and return value > of setup_routing_entry(), but 'e' was not freed incase of a failure. > > Signed-off-by: Sudip Mukherjee > --- > virt/kvm/irqchip.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c > index 21c1424..c63e54f 100644 > --- a/virt/kvm/irqchip.c > +++ b/virt/kvm/irqchip.c > @@ -213,11 +213,15 @@ int kvm_set_irq_routing(struct kvm *kvm, > goto out; > > r = -EINVAL; > - if (ue->flags) > + if (ue->flags) { > + kfree(e); > goto out; > + } > r = setup_routing_entry(new, e, ue); > - if (r) > + if (r) { > + kfree(e); > goto out; > + } > ++ue; > } > > Queued, thanks. Paolo