From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754295AbbIHIMX (ORCPT ); Tue, 8 Sep 2015 04:12:23 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52509 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754522AbbIHILY (ORCPT ); Tue, 8 Sep 2015 04:11:24 -0400 X-AuditID: cbfec7f5-f794b6d000001495-e7-55ee98296be3 Subject: Re: [PATCH] ARM: exynos_defconfig: Enable USB Video Class support To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1441662323-15468-1-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , Thierry Reding , Anand Moon , Russell King , linux-samsung-soc@vger.kernel.org, Lukasz Majewski , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <55EE9820.2010202@samsung.com> Date: Tue, 08 Sep 2015 17:11:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1441662323-15468-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4ZV3NGe9CDZb9U7F483YNk8XrF4YW /Y9fM1u8ebiZ0WLT42usFpd3zWGzmHF+H5PFuo232C1uX+a1uP2bz4HLo6W5h81j56y77B6b VnWyeWxeUu/R2/yOzWNLP1Cob8sqRo/Pm+QCOKK4bFJSczLLUov07RK4Mt4tn89W8Imn4vsx lgbGq1xdjJwcEgImElc7vzBC2GISF+6tZ+ti5OIQEljKKLF561wWCOcLo8S79cfYQaqEBbwk ppz/zgxiiwiESvy7eBusW0jATeLDwi2sIA3MAl1MEs2t3WwgCTYBY4nNy5ewQayQk+jtnsQC YvMKaEl8abrFCmKzCKhKdO38CjZUVCBC4tTZt2wQNYISPybfA6vnFHCXOPd/DVCcA2iBnsT9 i1ogYWYBeYnNa94yT2AUnIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn525i hMTL1x2MS49ZHWIU4GBU4uHV8HgXKsSaWFZcmXuIUYKDWUmE14YPKMSbklhZlVqUH19UmpNa fIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbGkHoZuWOvFi71OZ3Z1ZaldiZuvY6+ 4e7QhjyfU2Xq/roFrb91K8P3uff2x1ovn33t3fFXt6VNvt59/2vtquDwAzu23OToyttV4ryy kz8/5LiflpXMs74wycNK1leeO+fUFwbOP7HedyGnzt7b04rL5PIkpvfEbjOam5Lz65lRkLVS ePSMRVeUWIozEg21mIuKEwGw4OAOkwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.09.2015 06:45, Javier Martinez Canillas wrote: > The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in > Silicon Motion USB UVC WebCam. Enable support for the USB Video Class > driver and its needed media Kconfig symbols so the camera is supported. > > Signed-off-by: Javier Martinez Canillas > > --- > > arch/arm/configs/exynos_defconfig | 4 ++++ > 1 file changed, 4 insertions(+) The patch itself looks good but now I wonder whether we are not putting to much stuff built-in. The exynos_defconfig does not replace the distribution distro. For a fully working board the distro should prepare it's own config. I understand that in this case the USB webcams are parts of device (like on all laptops)... a little bit similar as camera sensors on mobile phones. Yet on mobile phone usually the camera itself is part of SoC, only the sensor is external. Actually what we need is a kind of policy for exynos_defconfig - what should be inside as built-in and what as module? Best regards, Krzysztof > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 1ff2bfa2e183..62f677f76a0b 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -126,6 +126,10 @@ CONFIG_REGULATOR_S2MPA01=y > CONFIG_REGULATOR_S2MPS11=y > CONFIG_REGULATOR_S5M8767=y > CONFIG_REGULATOR_TPS65090=y > +CONFIG_MEDIA_SUPPORT=y > +CONFIG_MEDIA_CAMERA_SUPPORT=y > +CONFIG_MEDIA_USB_SUPPORT=y > +CONFIG_USB_VIDEO_CLASS=y > CONFIG_DRM=y > CONFIG_DRM_NXP_PTN3460=y > CONFIG_DRM_PARADE_PS8622=y >