From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754506AbbIHJ2y (ORCPT ); Tue, 8 Sep 2015 05:28:54 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35541 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754076AbbIHJ2w (ORCPT ); Tue, 8 Sep 2015 05:28:52 -0400 Subject: Re: [PATCH v2 5/6] selftests: change install command to rsync To: Michael Ellerman References: <1441634692-19494-1-git-send-email-bamvor.zhangjian@linaro.org> <1441634692-19494-6-git-send-email-bamvor.zhangjian@linaro.org> <1441691528.14597.15.camel@ellerman.id.au> Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, khilman@linaro.org, tyler.baker@linaro.org, shuahkh@osg.samsung.com From: Bamvor Zhang Jian Message-ID: <55EEA994.8060207@linaro.org> Date: Tue, 8 Sep 2015 17:25:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441691528.14597.15.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Michael On 09/08/2015 01:52 PM, Michael Ellerman wrote: > On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote: >> The command of install could not handle the special files in exec >> testcases, change the default rule to rsync to fix this. >> The result of installation is unchanged after this commit. >> >> Suggested-by: Michael Ellerman >> Signed-off-by: Bamvor Jian Zhang > > Ah OK, I did suggest it. You never replied to my mail suggesting it though. > > I assume you tested it and it worked for all cases? yes, I compare the installed file. > >> diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selftests/ftrace/Makefile >> index 0acbeca..4e6ed13 100644 >> --- a/tools/testing/selftests/ftrace/Makefile >> +++ b/tools/testing/selftests/ftrace/Makefile >> @@ -1,7 +1,7 @@ >> all: >> >> TEST_PROGS := ftracetest >> -TEST_DIRS := test.d/ >> +TEST_DIRS := test.d >> >> include ../lib.mk >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index 97f1c67..50a93f5 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -12,13 +12,10 @@ run_tests: all >> $(RUN_TESTS) >> >> define INSTALL_RULE >> - @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \ >> - mkdir -p $(INSTALL_PATH); \ >> - for TEST_DIR in $(TEST_DIRS); do \ >> - cp -r $$TEST_DIR $(INSTALL_PATH); \ >> - done; \ >> - echo "install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)"; \ >> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); \ >> + @if [ "X$(TEST_PROGS)$(TEST_PROGS_EXTENDED)$(TEST_FILES)" != "X" ]; then \ >> + mkdir -p ${INSTALL_PATH}; \ >> + echo "rsync -a $(TEST_DIRS) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(INSTALL_PATH)/"; \ > > What is the echo for? For output the following rsync command during building. Do you mean there is some better way to do it? regards bamvor > >> + rsync -a $(TEST_DIRS) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) $(INSTALL_PATH)/; \ >> fi >> endef >> > > cheers > >