From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754658AbbIHKlM (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 06:41:12 -0400
Received: from mga01.intel.com ([192.55.52.88]:18581 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754489AbbIHKlI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 06:41:08 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,489,1437462000"; 
   d="scan'208";a="799951984"
Message-ID: <55EEBC33.5030906@intel.com>
Date: Tue, 08 Sep 2015 13:45:07 +0300
From: Mathias Nyman <mathias.nyman@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
CC: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>, Felipe Balbi <balbi@ti.com>,
        Sascha Hauer <s.hauer@pengutronix.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Roger Quadros <rogerq@ti.com>, linux-usb@vger.kernel.org,
        linux-mediatek@lists.infradead.org, John Crispin <blogic@openwrt.org>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller
References: <1441693083-8440-1-git-send-email-chunfeng.yun@mediatek.com> <1441693083-8440-5-git-send-email-chunfeng.yun@mediatek.com>
In-Reply-To: <1441693083-8440-5-git-send-email-chunfeng.yun@mediatek.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi

On 08.09.2015 09:18, Chunfeng Yun wrote:
> There some vendor quirks for MTK xhci host controller:
> 1. It defines some extra SW scheduling parameters for HW
>    to minimize the scheduling effort for synchronous and
>    interrupt endpoints. The parameters are put into reseved
>    DWs of slot context and endpoint context.
> 2. Its IMODI unit for Interrupter Moderation register is
>    8 times as much as that defined in xHCI spec.
> 3. Its TDS in  Normal TRB defines a number of packets that
>    remains to be transferred for a TD after processing all
>    Max packets in all previous TRBs.
>

I just rewrote and unified the the xhci TD remainder functions,
now we got only one xhci_td_remainder() function which should
be more suitable for quirks.

You can add the quirk directly to it, no need to duplicate the
whole function.

-Mathias