From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755296AbbIHPTQ (ORCPT ); Tue, 8 Sep 2015 11:19:16 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:34529 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740AbbIHPTO (ORCPT ); Tue, 8 Sep 2015 11:19:14 -0400 Subject: Re: [PATCH] block: Fix compiler warnings in blk-merge.c To: Geliang Tang References: <82bcc02d9e54f08453726d141a91ad3cf0ac2b2e.1441552898.git.geliangtang@163.com> Cc: linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <55EEFC70.1050202@kernel.dk> Date: Tue, 8 Sep 2015 09:19:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <82bcc02d9e54f08453726d141a91ad3cf0ac2b2e.1441552898.git.geliangtang@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2015 09:24 AM, Geliang Tang wrote: > Fix the following warnings: > > CC block/blk-merge.o > In file included from block/blk-merge.c:7:0: > block/blk-merge.c: In function ‘blk_queue_split’: > include/linux/blkdev.h:1368:21: warning: ‘bvprv.bv_offset’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q)); > ^ > block/blk-merge.c:70:21: note: ‘bvprv.bv_offset’ was declared here > struct bio_vec bv, bvprv; > ^ > In file included from block/blk-merge.c:7:0: > include/linux/blkdev.h:1368:21: warning: ‘bvprv.bv_len’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q)); > ^ > block/blk-merge.c:70:21: note: ‘bvprv.bv_len’ was declared here > struct bio_vec bv, bvprv; > ^ > In file included from ./arch/x86/include/asm/page.h:70:0, > from ./arch/x86/include/asm/thread_info.h:11, > from include/linux/thread_info.h:54, > from ./arch/x86/include/asm/preempt.h:6, > from include/linux/preempt.h:64, > from include/linux/spinlock.h:50, > from include/linux/seqlock.h:35, > from include/linux/time.h:5, > from include/linux/stat.h:18, > from include/linux/module.h:10, > from block/blk-merge.c:5: > include/asm-generic/memory_model.h:52:52: warning: ‘bvprv.bv_page’ may > be used uninitialized in this function [-Wmaybe-uninitialized] > #define __page_to_pfn(page) (unsigned long)((page) - vmemmap) > ^ > block/blk-merge.c:70:21: note: ‘bvprv.bv_page’ was declared here > struct bio_vec bv, bvprv; There's already a fix queued up for that, which doesn't require bvprv to be cleared to 0: http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=5014c311baa2b21384321fa4a9f617a92e3e56f0 -- Jens Axboe