From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755321AbbIHQaJ (ORCPT ); Tue, 8 Sep 2015 12:30:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:55965 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754858AbbIHQaF (ORCPT ); Tue, 8 Sep 2015 12:30:05 -0400 Subject: Re: [PATCH v2 1/9] mm/compaction: skip useless pfn when updating cached pfn To: Joonsoo Kim References: <1440382773-16070-1-git-send-email-iamjoonsoo.kim@lge.com> <1440382773-16070-2-git-send-email-iamjoonsoo.kim@lge.com> <55DADEC0.5030800@suse.cz> <20150907053528.GB21207@js1304-P5Q-DELUXE> Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman , Rik van Riel , David Rientjes , Minchan Kim From: Vlastimil Babka Message-ID: <55EF0D0B.9050409@suse.cz> Date: Tue, 8 Sep 2015 18:30:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150907053528.GB21207@js1304-P5Q-DELUXE> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2015 07:35 AM, Joonsoo Kim wrote: > On Mon, Aug 24, 2015 at 11:07:12AM +0200, Vlastimil Babka wrote: >> On 08/24/2015 04:19 AM, Joonsoo Kim wrote: >> >> In isolate_freepages_block() this means we actually go logically >> *back* one pageblock, as the direction is opposite? I know it's not >> an issue after the redesign patch so you wouldn't notice it when >> testing the whole series. But there's a non-zero chance that the >> smaller fixes are merged first and the redesign later... > > Hello, Vlastimil. > Sorry for long delay. I was on vacation. :) > I will fix it next time. > > Btw, if possible, could you review the patchset in detail? or do you I'll try soon... > have another plan on compaction improvement? Please let me know your > position to determine future plan of this patchset. > > Thanks. >