From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbbIHSM1 (ORCPT ); Tue, 8 Sep 2015 14:12:27 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:33543 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbbIHSMV (ORCPT ); Tue, 8 Sep 2015 14:12:21 -0400 From: Sergey Dyasly Subject: Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case To: Zhang Zhen References: <1441680050-50490-1-git-send-email-zhenzhang.zhang@huawei.com> <55EE4BD2.3080800@huawei.com> Cc: linux@arm.linux.org.uk, nico@linaro.org, ssantosh@kernel.org, vitalya@ti.com, treding@nvidia.com, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , Guan Xuetao , Nicolas Pitre , James Bottomley , Will Deacon , Arnd Bergmann , Catalin Marinas , Andrew Morton , Dmitry Safonov , Vladimir Murzin Message-ID: <55EF24FE.4060602@gmail.com> Date: Tue, 8 Sep 2015 21:12:14 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55EE4BD2.3080800@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.09.2015 5:45, Zhang Zhen wrote: > The arch-specific IOREMAP_MAX_ORDER is introduced in > commit: ff0daca([ARM] Add section support to ioremap) and > commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()). > But supersections and sections mappings are only used in !SMP && !LPAE case. > Otherwise, mapping is created using the usual 4K pages. > > In most cases without !SMP && !LPAE, the big alignment cause high fragmentation > issue in vmalloc area. > Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case, > otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h. > > Signed-off-by: Zhang Zhen > --- > arch/arm/include/asm/memory.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index b7f6fb4..3209012 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -76,10 +76,12 @@ > */ > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) > > +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) > /* > * Allow 16MB-aligned ioremap pages > */ > #define IOREMAP_MAX_ORDER 24 > +#endif > > #else /* CONFIG_MMU */ > Hmm... This looks exactly like my old patch - http://thread.gmane.org/gmane.linux.kernel.mm/127620 (Thanks to Vladimir for pointing that out!) Hasn't there been any progress about this issue?