From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbbIHUcf (ORCPT ); Tue, 8 Sep 2015 16:32:35 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36472 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbbIHUcc (ORCPT ); Tue, 8 Sep 2015 16:32:32 -0400 Subject: Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl() To: Xiao Guangrong References: <1440132611-26052-1-git-send-email-guangrong.xiao@linux.intel.com> <1440132611-26052-9-git-send-email-guangrong.xiao@linux.intel.com> <55ED74B3.3070202@redhat.com> <55EEEF81.2000502@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55EF45DC.9030401@redhat.com> Date: Tue, 8 Sep 2015 22:32:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55EEEF81.2000502@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/2015 16:24, Xiao Guangrong wrote: >> >> The second argument is always true. > > No... > > There are 3 places calling this function with set=falseļ¼š > nested_release_vmcs12(), vmx_disable_pml() and > vmx_cpuid_update() You're right. It's always constant---I don't know why I wrote it's always true, and then suggested vmcs_clear32... Paolo