From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbbIHV5G (ORCPT ); Tue, 8 Sep 2015 17:57:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57556 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbbIHV5B (ORCPT ); Tue, 8 Sep 2015 17:57:01 -0400 Message-ID: <55EF59A9.2010905@codeaurora.org> Date: Tue, 08 Sep 2015 16:56:57 -0500 From: Timur Tabi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Jonathan (Zhixiong) Zhang" , Matt Fleming , tony.luck@intel.com, fu.wei@linaro.org, al.stone@linaro.org, rjw@rjwysocki.net, mchehab@osg.samsung.com, mingo@redhat.com, bp@alien8.de, gong.chen@linux.intel.com CC: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, vgandhi@codeaurora.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH V2 1/2] efi: print unrecognized CPER section References: <1441747761-12012-1-git-send-email-zjzhang@codeaurora.org> <1441747761-12012-2-git-send-email-zjzhang@codeaurora.org> In-Reply-To: <1441747761-12012-2-git-send-email-zjzhang@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2015 04:29 PM, Jonathan (Zhixiong) Zhang wrote: > Change-Id: I663a6e3ae6dcf68e4e389f76d555e9106ffee165 You need to strip out the Change-Id's before posting the patch. > +#define cper_print_hex(pfx, buf, len) \ > + print_hex_dump(pfx, "", \ > + DUMP_PREFIX_OFFSET, ROW_SIZE, GROUP_SIZE, \ > + buf, len, 0) (buf), (len), 0) is safer > + } else { > + const void *raw_err = gdata + 1; > + printk("%ssection type: %pUl\n", pfx, sec_type); > + printk("%ssection length: %d\n", pfx, len); > + cper_print_hex(newpfx, raw_err, len); You don't need raw_err. This should work fine: cper_print_hex(newpfx, gdata + 1, len); -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.