From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754322AbbIHXAO (ORCPT ); Tue, 8 Sep 2015 19:00:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753999AbbIHXAI (ORCPT ); Tue, 8 Sep 2015 19:00:08 -0400 Subject: Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro To: Sudeep Holla , Al Stone , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <1440022048-6285-1-git-send-email-al.stone@linaro.org> <1440022048-6285-2-git-send-email-al.stone@linaro.org> <55EDADF5.5060008@arm.com> Cc: "linaro-kernel@lists.linaro.org" , "linux-ia64@vger.kernel.org" , "patches@linaro.org" , "linux-pm@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Len Brown From: Al Stone X-Enigmail-Draft-Status: N1110 Message-ID: <55EF6875.9000404@redhat.com> Date: Tue, 8 Sep 2015 17:00:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55EDADF5.5060008@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2015 09:32 AM, Sudeep Holla wrote: > Hi Al, > > On 19/08/15 23:07, Al Stone wrote: > > I finally got a chance to try this series on Juno. Well it exposed a firmware > bug in MADT table :) What? The code did what it was supposed to do :-)? Very cool. Good to know. I talked to Graeme a bit, too, and he had some good suggestions for clean up. I'll post a v3 tomorrow. > [..] > >> acpi_tbl_entry_handler handler, >> @@ -245,6 +484,8 @@ acpi_parse_entries(char *id, unsigned long table_size, >> table_end) { >> if (entry->type == entry_id >> && (!max_entries || count < max_entries)) { >> + if (bad_madt_entry(table_header, entry)) >> + return -EINVAL; > > Not sure if we can have the above check here unconditionally. > Currently I can see there are 2 other users of acpi_parse_entries i.e. > PCC and NUMA. So may be it can be made conditional or return success for > non-MADT tables from bad_madt_entry ? I'll double check these uses. I thought I had before, and based on what I saw the check would be reasonable. It never hurts to check again, though. > Other than that, you can add for ARM64 specific parts: > Reviewed-and-tested-by: Sudeep Holla Thanks! > Regards, > Sudeep > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. ahs3@redhat.com -----------------------------------