Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label

Krzysztof Kozlowski
2015-09-10T00:27:48Z

On 08.09.2015 18:38, Robert Baldyga wrote:
> This label does nothing special and we don't need to have it anymore.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
> drivers/tty/serial/samsung.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)

Label does nothing but it has a meaning. It serves as a comment - ignore
the character. So maybe:

- goto ignore_char;
+ continue; /* Ignore character */

What do you think?

Best regards,
Krzysztof

>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index fee764c..2b05194 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -676,7 +676,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id)
> dbg("break!\n");
> port->icount.brk++;
> if (uart_handle_break(port))
> - goto ignore_char;
> + continue;
> }
>
> if (uerstat & S3C2410_UERSTAT_FRAME)
> @@ -696,13 +696,10 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id)
> }
>
> if (uart_handle_sysrq_char(port, ch))
> - goto ignore_char;
> + continue;
>
> uart_insert_char(port, uerstat, S3C2410_UERSTAT_OVERRUN,
> ch, flag);
> -
> -ignore_char:
> - continue;
> }
>
> spin_unlock_irqrestore(&port->lock, flags);
>