From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857AbbIIFjz (ORCPT ); Wed, 9 Sep 2015 01:39:55 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35716 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932129AbbIIFji (ORCPT ); Wed, 9 Sep 2015 01:39:38 -0400 Subject: Re: [PATCH-v2 2/7] mmc: sdhci-pxav3: binding: Add pxa1928 compatible support To: Vaibhav Hiremath , linux-mmc@vger.kernel.org References: <1441624721-15612-1-git-send-email-vaibhav.hiremath@linaro.org> <1441624721-15612-3-git-send-email-vaibhav.hiremath@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, ulf.hansson@linaro.org From: Rob Herring Message-ID: <55EF740A.1020204@kernel.org> Date: Tue, 8 Sep 2015 18:49:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441624721-15612-3-git-send-email-vaibhav.hiremath@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote: > With support for pxa1928 family of devices , this patch > updates the binding document with compatible property > of "marvell,pxav3-1928-sdhci". > > Signed-off-by: Vaibhav Hiremath > --- > Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt > index 3d1b449..29edcf5 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt > @@ -5,7 +5,7 @@ and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers. > > Required properties: > - compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or > - "marvell,armada-380-sdhci". > + "marvell,armada-380-sdhci" or "marvell,pxav3-1928-sdhci". v3 is implied by pxa1928. So I'd just do "marvell,pxa1928-sdhci" to better match the chip name. Rob > - reg: > * for "mrvl,pxav2-mmc" and "mrvl,pxav3-mmc", one register area for > the SDHCI registers. >