From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292AbbIIFmy (ORCPT ); Wed, 9 Sep 2015 01:42:54 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34951 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932105AbbIIFjw (ORCPT ); Wed, 9 Sep 2015 01:39:52 -0400 Subject: Re: [PATCH v7 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs To: Chunfeng Yun , Mathias Nyman References: <1441693083-8440-1-git-send-email-chunfeng.yun@mediatek.com> <1441693083-8440-2-git-send-email-chunfeng.yun@mediatek.com> Cc: Rob Herring , Mark Rutland , Matthias Brugger , Felipe Balbi , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin , Daniel Kurtz , Sergei Shtylyov , Kishon Vijay Abraham I , Pawel Moll , Ian Campbell , Kumar Gala , Greg Kroah-Hartman From: Rob Herring X-Enigmail-Draft-Status: N1110 Message-ID: <55EF7A70.1080701@kernel.org> Date: Tue, 8 Sep 2015 19:16:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441693083-8440-2-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2015 01:17 AM, Chunfeng Yun wrote: > add a DT binding documentation of usb3.0 phy for MT65xx > SoCs from Mediatek. > > Signed-off-by: Chunfeng Yun One comment, otherwise: Acked-by: Rob Herring > --- > .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt > new file mode 100644 > index 0000000..5812d20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt > @@ -0,0 +1,69 @@ > +mt65xx USB3.0 PHY binding > +-------------------------- > + > +This binding describes a usb3.0 phy for mt65xx platforms of Medaitek SoC. > + > +Required properties (controller (parent) node): > + - compatible : should be "mediatek,mt8173-u3phy" > + - reg : offset and length of register for phy, exclude port's > + register. > + - clocks : a list of phandle + clock-specifier pairs, one for each > + entry in clock-names > + - clock-names : must contain > + "u3phya_ref": for reference clock of usb3.0 analog phy. > + > +Required nodes : a sub-node is required for each port the controller > + provides. Address range information including the usual > + 'reg' property is used inside these nodes to describe > + the controller's topology. These nodes are translated > + by the driver's .xlate() function. The last sentence is Linux specific. Please remove. > + > +Required properties (port (child) node): > +- reg : address and length of the register set for the port. > +- #phy-cells : should be 1 (See second example) > + cell after port phandle is phy type from: > + - PHY_TYPE_USB2 > + - PHY_TYPE_USB3 > + > +Example: > + > +u3phy: usb-phy@11290000 { > + compatible = "mediatek,mt8173-u3phy"; > + reg = <0 0x11290000 0 0x800>; > + clocks = <&apmixedsys CLK_APMIXED_REF2USB_TX>; > + clock-names = "u3phya_ref"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + status = "okay"; > + > + phy_port0: port@11290800 { > + reg = <0 0x11290800 0 0x800>; > + #phy-cells = <1>; > + status = "okay"; > + }; > + > + phy_port1: port@11291000 { > + reg = <0 0x11291000 0 0x800>; > + #phy-cells = <1>; > + status = "okay"; > + }; > +}; > + > +Specifying phy control of devices > +--------------------------------- > + > +Device nodes should specify the configuration required in their "phys" > +property, containing a phandle to the phy port node and a device type; > +phy-names for each port are optional. > + > +Example: > + > +#include > + > +usb30: usb@11270000 { > + ... > + phys = <&phy_port0 PHY_TYPE_USB3>; > + phy-names = "usb3-0"; > + ... > +}; >