From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754904AbbIIFkR (ORCPT ); Wed, 9 Sep 2015 01:40:17 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35056 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754859AbbIIFj5 (ORCPT ); Wed, 9 Sep 2015 01:39:57 -0400 Subject: Re: [PATCH v7 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller To: Chunfeng Yun , Mathias Nyman References: <1441693083-8440-1-git-send-email-chunfeng.yun@mediatek.com> <1441693083-8440-3-git-send-email-chunfeng.yun@mediatek.com> Cc: Mark Rutland , Matthias Brugger , Felipe Balbi , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros , linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, John Crispin , Daniel Kurtz , Sergei Shtylyov , Kishon Vijay Abraham I , Pawel Moll , Ian Campbell , Kumar Gala , Greg Kroah-Hartman From: Rob Herring X-Enigmail-Draft-Status: N1110 Message-ID: <55EF7DB0.7040607@kernel.org> Date: Tue, 8 Sep 2015 19:30:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441693083-8440-3-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2015 01:18 AM, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > new file mode 100644 > index 0000000..d851bf1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > @@ -0,0 +1,52 @@ > +MT8173 xHCI > + > +The device node for Mediatek SOC USB3.0 host controller > + > +Required properties: > + - compatible : should contain "mediatek,mt8173-xhci" > + - reg : specifies physical base address and size of the registers, > + the first one for MAC, the second for IPPC > + - interrupts : interrupt used by the controller > + - power-domains : a phandle to USB power domain node to control USB's > + mtcmos > + - vusb33-supply : regulator of USB avdd3.3v > + > + - clocks : a list of phandle + clock-specifier pairs, one for each > + entry in clock-names > + - clock-names : must contain > + "sys_ck": for clock of xHCI MAC > + "wakeup_deb_p0": for USB wakeup debounce clock of port0 > + "wakeup_deb_p0": for USB wakeup debounce clock of port1 > + > + - phys : a list of phandle + phy specifier pairs > + - usb3-lpm-capable : supports USB3.0 LPM > + - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup > + control register Wake-up should probably be done in some generic way. That said, I don't have a specific suggestion other than make it optional. > + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup > + mode; Others means don't enable wakeup source of USB This should be optional rather than any other value meaning disabled. > + > +Optional properties: > + - vbus-supply : reference to the VBUS regulator; > + > +Example: > +usb30: usb@11270000 { > + compatible = "mediatek,mt8173-xhci"; > + reg = <0 0x11270000 0 0x1000>, > + <0 0x11280700 0 0x0100>; > + interrupts = ; > + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>; > + clocks = <&topckgen CLK_TOP_USB30_SEL>, > + <&pericfg CLK_PERI_USB0>, > + <&pericfg CLK_PERI_USB1>; > + clock-names = "sys_ck", > + "wakeup_deb_p0", > + "wakeup_deb_p1"; > + phys = <&phy_port0 PHY_TYPE_USB3>, > + <&phy_port1 PHY_TYPE_USB2>; > + vusb33-supply = <&mt6397_vusb_reg>; > + vbus-supply = <&usb_p1_vbus>; > + usb3-lpm-capable; > + mediatek,syscon-wakeup = <&pericfg>; > + mediatek,wakeup-src = <1>; > + status = "okay"; > +}; >