From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754565AbbIIBjN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 21:39:13 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:8206 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753918AbbIIBjC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 21:39:02 -0400
Message-ID: <55EF89E6.2000401@huawei.com>
Date: Wed, 9 Sep 2015 09:22:46 +0800
From: Zhang Zhen <zhenzhang.zhang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Sergey Dyasly <dserrg@gmail.com>
CC: <linux@arm.linux.org.uk>, <nico@linaro.org>, <ssantosh@kernel.org>,
        <vitalya@ti.com>, <treding@nvidia.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Guan Xuetao <gxt@mprc.pku.edu.cn>,
        "Nicolas Pitre" <nicolas.pitre@linaro.org>,
        James Bottomley <JBottomley@parallels.com>,
        Will Deacon <will.deacon@arm.com>,
        Arnd Bergmann <arnd.bergmann@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dmitry Safonov <d.safonov@partner.samsung.com>,
        Vladimir Murzin <murzinv@gmail.com>
Subject: Re: [PATCH] ARM:mm: define arch-specific IOREMAP_MAX_ORDER only in
 !SMP && !LPAE case
References: <1441680050-50490-1-git-send-email-zhenzhang.zhang@huawei.com> <55EE4BD2.3080800@huawei.com> <55EF24FE.4060602@gmail.com>
In-Reply-To: <55EF24FE.4060602@gmail.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.68.57]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/9/9 2:12, Sergey Dyasly wrote:
> On 08.09.2015 5:45, Zhang Zhen wrote:
>> The arch-specific IOREMAP_MAX_ORDER is introduced in
>> commit: ff0daca([ARM] Add section support to ioremap) and
>> commit: a069c89 ([ARM] 3705/1: add supersection support to ioremap()).
>> But supersections and sections mappings are only used in !SMP && !LPAE case.
>> Otherwise, mapping is created using the usual 4K pages.
>>
>> In most cases without !SMP && !LPAE, the big alignment cause high fragmentation
>> issue in vmalloc area.
>> Here we use arch-specific IOREMAP_MAX_ORDER only in !SMP && !LPAE case,
>> otherwise use generic IOREMAP_MAX_ORDER in include/linux/vmalloc.h.
>>
>> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
>> ---
>>   arch/arm/include/asm/memory.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
>> index b7f6fb4..3209012 100644
>> --- a/arch/arm/include/asm/memory.h
>> +++ b/arch/arm/include/asm/memory.h
>> @@ -76,10 +76,12 @@
>>    */
>>   #define XIP_VIRT_ADDR(physaddr)  (MODULES_VADDR + ((physaddr) & 0x000fffff))
>>
>> +#if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE)
>>   /*
>>    * Allow 16MB-aligned ioremap pages
>>    */
>>   #define IOREMAP_MAX_ORDER    24
>> +#endif
>>
>>   #else /* CONFIG_MMU */
>>
> 
> Hmm... This looks exactly like my old patch -
> http://thread.gmane.org/gmane.linux.kernel.mm/127620
> (Thanks to Vladimir for pointing that out!)
> 
> Hasn't there been any progress about this issue?
> 
Oh sorry i didn't notice your old patch.
I send this patch because we encountered high fragmentation issue in vmalloc area
and the link about this issue.
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/313040.html
Let's drop my patch.

Besides, i just want to know why this patch is not included into the upstream kernel?

Thanks!
> .
>