From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbbIIMRI (ORCPT ); Wed, 9 Sep 2015 08:17:08 -0400 Received: from mail-by2on0087.outbound.protection.outlook.com ([207.46.100.87]:36830 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752066AbbIIMRA (ORCPT ); Wed, 9 Sep 2015 08:17:00 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NUESS4-08-3IL-02 X-M-MSG: Subject: Re: [PATCH V3 0/4] PCI: ACPI: Setting up DMA coherency for PCI device from _CCA attribute To: , , , , References: <1440597279-11802-1-git-send-email-Suravee.Suthikulpanit@amd.com> CC: , , , , From: "Suthikulpanit, Suravee" Message-ID: <55F02331.2060001@amd.com> Date: Wed, 9 Sep 2015 19:16:49 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1440597279-11802-1-git-send-email-Suravee.Suthikulpanit@amd.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(189002)(24454002)(377454003)(53754006)(199003)(164054003)(62966003)(77156002)(50466002)(64706001)(87936001)(19580395003)(4001350100001)(80316001)(11100500001)(65816999)(50986999)(5001830100001)(4001540100001)(87266999)(106466001)(76176999)(15975445007)(33656002)(97736004)(5001860100001)(46102003)(5007970100001)(92566002)(36756003)(189998001)(83506001)(47776003)(54356999)(77096005)(5001770100001)(86362001)(64126003)(68736005)(2201001)(105586002)(101416001)(23746002)(2950100001)(65956001)(59896002)(65806001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0718;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;2:LEDLFuPKIae0VGSjiu39v9i4HSBZ6nAI7eFfi02JH89n9PGWV+bUlG3Ln+tYoSlTM8nMzGVkOJY+2+yjRBeg1rev5ZPM+9mWrf3s7ZuFCWRcapBn4eHIqKQUIi8LHg8hyH6sRVod3FXhoHRXa41WbSMQsDEqvAFS2doHpAT2Fyk=;3:ffgWC6YRFwlLadA9DONVH41MOVfxtrIiiBf9LkGomDK+6V62lgThmkrFoHmvNGqDL4j5JW0eKABQiuapyfH9UyB/H5rRfmt8763o7h0wJ6yG9k4/0p0RRjZlnDV1rTWmFAYaeM/rOAN+6XJWgDHBG3WraLsZ5dUCfmHN87k5xi6+EtFB9m4JQO/D0mcey7T4NXX47P8zHggIiyLULMkRwogRwBlgauPNyY3U3oDsVvyAKQpGFJCIr78rzLLW3Sl8;25:xcqxWK3/aow/7VC8Sp13p1f3fcEsYUK7IbAWO4NjheYcprdGq/9F6qSonqblFOzrhoPuuh0orPZ6M7dhsy1X7z1PcBe7SZx4ZA4zlb1lvKPiNPXAvJebNkibuf50HsmvTOwQrepbIiVdTpktaZa2S5dLR+1iNFY1FuDVETZFZG1kfOQjLCRwcGZrXxj3mH5jUxl0Tmpcc4JncM8lPqZVqcnG0r8RZLr7hZ6SZJnfd+mlKmKBHI2jo34S8et8/aaY X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0718; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;20:uueWkx1SegqtWgogCj9n8V6DPEfhJEbOjv8va+FGoQvb3s0f5EE9+U5d4Gn+Soi75kNIAkqI1g1ucOrvNwbu1fHi7mqaW13hn5OctVSy461nUN0ewvd6lYXv7dOFCd+2XELa1jNUjpIqPDuqqRKJp8HkOfwNCF7O9tujowPqGAh4N310/haZUjh8yIbtpuGTIsUbf1yLeJuGfrJPAHkPuv5QZCNtEDUF7PlgNIR6tnR5JFAQ3AgtOKLa5PIJQbyMcGHN6qPrQ8LTfVvUFpznFPU71fDgWEf/ZUkcYex0ZeALbnju91X4UJZSY6fhCvp+yTHD1oYVJLXaEitkjqgfQf1HEsz5WI1CYBg+OlMW922zhKFFa14DfvAapKfTeNiNHOY2XIhhSlASvfrRBC9xYmGMj+MdsZZwH/sICtj7Uk7j3xXY6V4epiSwC30PQw8TEgKSdzHVfoISNHLuG5/LSmRrtnaw5Le2OjweuanLHloItQet6XTC8/z9LWCBoP/Y;4:DdJ1Ny9eMc90KoiBobGxIB19e/vQ6MVc9X4P2nxtVghXz3tpF+P0MpDyjbVwTIWthzBz0qlPOm+iJ5TBk+Ko8bKNd+6DcXH6zsTypNtdJyLYRnAOciSKAdb4NLi/qChn7r565+NP6UJO64qOtv3nBCrYY+e2sQi1YogA4Pd4/Twi0C7WAzfhGbAhn7eGx5gDRBmJKmZZAilmz5xae5oKXBQNJqbmvfblSMIfWA1ayq2DOWRS6kIV3jpgd0viUFvTBrRm3oKZgxca/sZc9kOuI8vLoRz8ki7ktCK342cTJcxdhgmT+fHPh5gmxkBZtbBn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:SN1PR12MB0718;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0718; X-Forefront-PRVS: 0694C54398 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0718;23:rGDO1VHbmY9vudqt8AXcZKr40LxVLrkog0M2k?= =?Windows-1252?Q?7oFALGM5SZTovqFTVOwTysQjVFKkCc+psFh4KMsZOss2oY19GPg1c8kC?= =?Windows-1252?Q?PHOj+u3ojODg1NkHuGYq3nP7rVBIgwqBAsggsV++7hEN03eaSQnFgU19?= =?Windows-1252?Q?fDGSYjMh7uLtmdsk15x0AAssGmFiXJr7m2fWxmO2VzpXSpgt0xCK+61q?= =?Windows-1252?Q?Ps7+uOla718eUaZiQTSL0VWOBJ0Fw2WwbWao7EpXpTtLAXOcG2Pk3429?= =?Windows-1252?Q?t1podK4Ey7RTxIAiZRorlGm98xclQTQWOe7+J3aUllFgaYTQvfv42W2c?= =?Windows-1252?Q?dmgCq6IoPdDyUwi0OHD8HMiIdihpLjpdXWt1fb1xwPNrh+kuNZhyktfb?= =?Windows-1252?Q?8mekITpmRur7pbjHKZhpN9u4y0BNVnEzkmb9d/4FX/7fepM6NyHS00gj?= =?Windows-1252?Q?EIAOlGJLrUlm9FHiNb7dEGEOLmVFaf+7ThGScJut+G+2bFWkIPoLKIBq?= =?Windows-1252?Q?nJWZeKiejJMfu0y9vDvI3lUW90anQ0x1Uas5wZWtDmI6RzEDnaB8ClU+?= =?Windows-1252?Q?SANt057bnQgfC3n45R6eKL1NFetHWFSsxyEqXBoVU9J6v4FsSKdFmSOj?= =?Windows-1252?Q?lN8kxFqnMeCDP7XAnYPBvs1y6wDBOt8Ifs0PUApWX8kbIhoKAp0qmKAU?= =?Windows-1252?Q?agI2j2P0lgJWG0ixKBT6t8Tfm5ctUQ76HzA550CIwqmYRBPt9tfXQ1NM?= =?Windows-1252?Q?F89FheVz6jpO1awy1mUdpljMKu5gw8xGwqvAHOcoXR5myfob01t0kSSn?= =?Windows-1252?Q?lipW7Bb5rmk4QtHJJSqOBuI1dUeoiIdRog8FGnD+0kgXch36+e2slO+o?= =?Windows-1252?Q?AQ8j2Uz7cB/+3FRNbO80PoBf0+LR3wFf8dmQbdDfvvEVPvHISNWZQbT0?= =?Windows-1252?Q?N1zhoSJgOtLKtYRc9IzgA3jmeG45QdM4x0K63c93FvK+moSZLSw6a124?= =?Windows-1252?Q?0yCDUILrD/s2CJkdncdY71khVbgJGt56ik0KYdZN3CzCMoFjgtZJ/r4f?= =?Windows-1252?Q?NpiDE4Yg5jkngq58FE+MkOqjPbd8upljTHeW4S9b3zXbgAYFfenuJ1At?= =?Windows-1252?Q?hERBBlUsfiXoWgbEpYP0Jx6blk7MxblqJVU+JzXygvpfhQuF2f9+FttE?= =?Windows-1252?Q?DAIT9e5GEIDiciZSuoytpRrQIRyTN8YjTPeZ/3dMWPVAfXckBbXU4qVk?= =?Windows-1252?Q?qeRL++jcf5nWt5NkW6eg61qGsCeeYrKxnfrfqOgwqGuNUdT8WPMLqDah?= =?Windows-1252?Q?DgkHyiu/9WeRZmyyIh0xdqlyKAhljyW3fibY64eTFCXm70efhQSB/UVI?= =?Windows-1252?Q?ItxgfHM9jAOb9AF1uc/5+X8CqZCjuqBKJAIErAgCMz1iTDvX8U1u8ruv?= =?Windows-1252?Q?Nu5dkajnj8ml55eCNxp?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0718;5:VfzwajXX/ZY1XNYas3eXLWIhTrE35YOUVx7RTeBZUZ/JY8XpLDuXLl7sVVNCFEbJ0sC+KE1TwiPHRO3F6CrMeTFAUFAQpJFZodXs4XfK9u4LjNFEjf0NLw/a/VRqu4OxMqBBm/t0Kw/qhPTstOBCyQ==;24:PISmBqW+JaAP71wxHyKiCdZNFEFIMz0gjT0WjIzNbHnXMPMFEtUqoqq32cTCENOjz5UQjlsZJnnwDtoQ2MH8+gnFo5/aJFWBDDOIw30pi4k=;20:PQcfxWdvNSY0IMtkjPDnsAZpuDq6ZhZHqdxr55L+ICfkf0V/ivd6oNyAn4X09nuzFK0XkhIE3V7qAUmowOmlQw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2015 12:16:56.2206 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0718 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0910;2:w/ouzg3Bz3yuUwEsWG+yVB5/N9c6WiB04ZQaz4b8/+U92a6eaurhZGLeSXUJJHkhoWsSsUvaTnQIr2cZlzEG/iTIgyyCV9AOjD5p6YL/cG5oGDz+snBaeb+/YGQ6bHmzqyIUpID9DwQSMUGaqeiuWa4c9T+Rpe9bGfDVPNKKjyM=;23:zgDb20LEN9O9CJUTGWKtwajOThfMSshYSOxzbhKdFRj/mPFBaZ4UCWuzIe0rmBcn9voa8HdoxYEzaVb9y3tKsNczMVYsnySXFYuVEgRY3nRPVHNF7vfEC2pEVTcKlkLJY4YOkHMBaJ/X1X0eCK+GyXUHSy7lOqs+BKkLXbnMe2fJZ1T8bz2PrpwgAD+jitYa X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, Are there any other concerns about this patch series? Thanks, Suravee On 8/26/2015 8:54 PM, Suravee Suthikulpanit wrote: > This patch adds support to setup DMA coherency for PCI device using > the ACPI _CCA attribute. According to the ACPI spec, the _CCA attribute > is required for ARM64. Therefore, this patch is a pre-req for ACPI PCI > support for ARM64 which is currently in development. > > Also, this should not affect other architectures that does not define > CONFIG_ACPI_CCA_REQUIRED, since the default value is coherent. > > I have included the following patch from Jeremy before cleaning up > the acpi_check_dma() function (in patch 2). > > http://www.spinics.net/lists/linux-usb/msg128582.html) > > Changes from V2: (https://lkml.org/lkml/2015/8/25/549) > * Return -ENOSUPP instead of -1 (per Rafael's suggestion) > * Add WARN() when fail to setup DMA for PCI device when booting > ACPI (per Arnd's suggestion) > * Added Acked-by from Rob. > * Minor clean up > > Changes from V1: (https://lkml.org/lkml/2015/8/13/182) > * Include patch 1 from Jeremy to enable support for _CCA=0 > * Clean up acpi_check_dma() per Bjorn suggestions > * Split the original V1 patch into two patches (patch 3 and 4) > > > Jeremy Linton (1): > Honor ACPI _CCA attribute setting > > Suravee Suthikulpanit (3): > ACPI/scan: Clean up acpi_check_dma > PCI: OF: Move of_pci_dma_configure() to pci_dma_configure() > PCI: ACPI: Add support for PCI device DMA coherency > > drivers/acpi/acpi_platform.c | 7 ++++++- > drivers/acpi/glue.c | 6 +++--- > drivers/acpi/scan.c | 39 +++++++++++++++++++++++++++++++++++++++ > drivers/base/property.c | 10 +++++++--- > drivers/of/of_pci.c | 20 -------------------- > drivers/pci/probe.c | 35 +++++++++++++++++++++++++++++++++-- > include/acpi/acpi_bus.h | 35 ++--------------------------------- > include/linux/acpi.h | 4 ++-- > include/linux/of_pci.h | 3 --- > 9 files changed, 92 insertions(+), 67 deletions(-) >