From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753389AbbIIO0V (ORCPT ); Wed, 9 Sep 2015 10:26:21 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37183 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbbIIO0N (ORCPT ); Wed, 9 Sep 2015 10:26:13 -0400 Message-ID: <55F04182.2000707@ultimaker.com> Date: Wed, 09 Sep 2015 16:26:10 +0200 From: Olliver Schinagl Organization: Ultimaker B.V. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Maxime Ripard CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Add eeprom to the Olimex series of boards References: <1441790715-11957-1-git-send-email-o.schinagl@ultimaker.com> <20150909140559.GD9885@lukather> In-Reply-To: <20150909140559.GD9885@lukather> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09-09-15 16:05, Maxime Ripard wrote: > On Wed, Sep 09, 2015 at 11:25:10AM +0200, Olliver Schinagl wrote: >> Some of the olimex series of boards feature a permanently connected eeprom on >> i2c-1. This patch series adds them on all the boards that have them according >> to the spec-sheets. >> >> I explicitly added my personal --Tested-by to boards I actually tested. > Testing your changes is the strict minimum before testing your > patches. Just like running checkpatch on them, which you clearly > failed to do, otherwise you would have seen that this is not the right > syntax. Drop the tested-by, fix your SoB. Actually, I did run check-patch and it complained about the format, but it was the same as when outputted with a git -s. I obviously missed something there! So I double check that. I will resubmit without a tested-by for the boards I did test it on. > >> There are two boards, that according to the sheets have them as well >> and physically inspecting the boards shows them clearly, I did not >> actually test them on those the boards that are missing the >> --Tested-by. > Then don't send those patches. I put them out there so someone could pick up on that with the least amount of effort. I will drop them > > Maxime > -- Met vriendelijke groeten, Kind regards, 与亲切的问候 Olliver Schinagl Research & Development Ultimaker B.V.