From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755853AbbIIVUS (ORCPT ); Wed, 9 Sep 2015 17:20:18 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:55866 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214AbbIIVUO (ORCPT ); Wed, 9 Sep 2015 17:20:14 -0400 Subject: Re: [PATCH 3/3] staging: fbtft: use pr_fmt To: Greg Kroah-Hartman , Sudip Mukherjee References: <1441460625-19026-1-git-send-email-sudipm.mukherjee@gmail.com> <1441460625-19026-3-git-send-email-sudipm.mukherjee@gmail.com> <20150909183526.GA15171@kroah.com> Cc: Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <55F0A288.10206@tronnes.org> Date: Wed, 9 Sep 2015 23:20:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150909183526.GA15171@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 09.09.2015 20:35, skrev Greg Kroah-Hartman: > On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote: >> Instead of defining DRVNAME and using it in all calls to pr_* family of >> macros lets start using pr_fmt. >> >> Signed-off-by: Sudip Mukherjee >> --- >> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++-------------------- >> 1 file changed, 35 insertions(+), 44 deletions(-) [...] > If a driver is working properly, nothing should show up in the kernel > log at all, otherwise it's just noise that everyone ignores. This isn't a device driver, it's a module for adding "fbtft" devices (spi/platform with pdata). When I created fbtft, the Raspberry Pi didn't have Device Tree support, so I made this module as a way for the end user to add devices without having to build a kernel. I haven't seen any module like this in the kernel, so maybe it really doesn't belong here at all? Noralf.