Re: [PATCH 3/3] staging: fbtft: use pr_fmt

Noralf Trønnes
2015-09-10T16:45:23Z

10.09.2015 06:54, skrev Sudip Mukherjee:
> On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote:
>> Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
>>> On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
>>>> Instead of defining DRVNAME and using it in all calls to pr_* family of
>>>> macros lets start using pr_fmt.
>>>>
>>>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>>> ---
>>>> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++--------------------
>>>> 1 file changed, 35 insertions(+), 44 deletions(-)
>> [...]
>>
>>> If a driver is working properly, nothing should show up in the kernel
>>> log at all, otherwise it's just noise that everyone ignores.
>> This isn't a device driver, it's a module for adding "fbtft" devices
>> (spi/platform with pdata). When I created fbtft, the Raspberry Pi didn't
>> have Device Tree support, so I made this module as a way for the end user
>> to add devices without having to build a kernel.
>> I haven't seen any module like this in the kernel, so maybe it
>> really doesn't
>> belong here at all?
> Is this driver only for Raspberry Pi?
> I have seen someone submitted a drm driver for Raspberry Pi. And I guess
> that is already merged.
> Tomi (fbdev maintainer) said "Fremebuffer driver will be obsolete
> immediately when there's a DRM driver for that device". And if a drm
> driver is already there for Raspberry Pi then ?

Not sure what you refer to as driver here.

The fbtft module presents a simplistic view of fbdev through
'struct fbtft_par' which the various fbtft drivers use.

fbtft_device is just a kernel module that can add spi and platform
devices to the kernel and it can be used on all platforms. It's not a
driver of any kind. It really does what Device Tree does, it adds devices.

vc4 is an upcoming DRM driver for the BCM2835 display hardware (hdmi).
This has nothing to do with the fbtft drivers which target SPI/parallel
bus connected displays with onboard video memory.

Noralf.