Re: [PATCH 3/3] staging: fbtft: use pr_fmt

Sudip Mukherjee
2015-09-11T10:38:58Z

On Thu, Sep 10, 2015 at 06:45:15PM +0200, Noralf Trønnes wrote:
>
> 10.09.2015 06:54, skrev Sudip Mukherjee:
> >On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote:
> >>Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
> >>>On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
> >>>>Instead of defining DRVNAME and using it in all calls to pr_* family of
> >>>>macros lets start using pr_fmt.
> >>>>
> >>>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >>>>---
> >>>> drivers/staging/fbtft/fbtft_device.c | 79 ++++++++++++++++--------------------
> >>>> 1 file changed, 35 insertions(+), 44 deletions(-)
> >>[...]
> >>
<snip>
> >Is this driver only for Raspberry Pi?
> >I have seen someone submitted a drm driver for Raspberry Pi. And I guess
> >that is already merged.
> >Tomi (fbdev maintainer) said "Fremebuffer driver will be obsolete
> >immediately when there's a DRM driver for that device". And if a drm
> >driver is already there for Raspberry Pi then ?
>
> Not sure what you refer to as driver here.
>
> The fbtft module presents a simplistic view of fbdev through
> 'struct fbtft_par' which the various fbtft drivers use.
>
> fbtft_device is just a kernel module that can add spi and platform
> devices to the kernel and it can be used on all platforms. It's not a
> driver of any kind. It really does what Device Tree does, it adds devices.
>
> vc4 is an upcoming DRM driver for the BCM2835 display hardware (hdmi).
> This has nothing to do with the fbtft drivers which target SPI/parallel
> bus connected displays with onboard video memory.
Ok, Thanks for explaining. Since this is using calls to framebuffer I
thought this to be a framebuffer driver.
Anyways, I will modify the patch as suggested by Greg.

regards
sudip