From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754187AbbIIXrx (ORCPT ); Wed, 9 Sep 2015 19:47:53 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24335 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbbIIXru (ORCPT ); Wed, 9 Sep 2015 19:47:50 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-87-55f0c52350d7 Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger To: "Pallala, Ramakrishna" References: <1441560187-23611-1-git-send-email-ramakrishna.pallala@intel.com> Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Sebastian Reichel , "Tc, Jenny" , Andreas Dannenberg From: Krzysztof Kozlowski Message-id: <55F0C522.6070705@samsung.com> Date: Thu, 10 Sep 2015 08:47:46 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xq7rKRz+EGtx9Lmix+soUdov5R86x Wqz92sNu8fqFocXlXXPYLD73HmG0WPjmJpPF6d0lDhwei/e8ZPLYtKqTzaNvyypGj+M3tjN5 fN4kF8AaxWWTkpqTWZZapG+XwJVxY98hxoLZnBXzd21maWBczd7FyMkhIWAisfp5CyuELSZx 4d56ti5GLg4hgaWMEh/vz2GBcL4wSqz+NYcJpEpYwF/iZPtzRhBbRMBKov3gZmaIonuMEt+n PWMDSTALrGSSmLEiG8RmEzCW2Lx8CVicV0BLYs+bVrBmFgFViSVvNrGA2KICERKnzr6FqhGU +DH5HlicUyBMYsm3j0BxDqCZ6hJTpuRCjJeX2LzmLfMERoFZSDpmIVTNQlK1gJF5FaNoamly QXFSeq6hXnFibnFpXrpecn7uJkZIqH/Zwbj4mNUhRgEORiUe3gkt70OFWBPLiitzDzFKcDAr ifCmbf8QKsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQZG 7+fKyoe2qcxd477p8JKXXh8Ng95czGyediDAYLHSpLAepy0MR1ItMjhdxfUYfkmWMNW/3B15 8K2Et6dRb9fjJ/eXMW0MerHRbMmzU/zPpL+9kp3qdSxvan7QSXYd30MPNil/VljEHGocddTC 3uXruY9es6omauacd/is/X+/tvb6eV4ra1IqlFiKMxINtZiLihMBgAXhUHECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.09.2015 03:11, Pallala, Ramakrishna wrote: >>> +Optional properties: >>> +- ti,thermal-sensing: boolean, if present thermal regulation will be >>> +enabled; >> >> What is the requirement for thermal-sensing? Can it be enabled always? >> If yes, then this is not really a hardware property. > TI BQ24261 has provision to add Battery Pack thermistor but it has no ADC read it. > So a HW designer would or may not add the thermistor to charger and instead he can > connect to the Fuel Gauge. Thanks for explanation, makes sense. > >>> +- ti,enable-user-write: boolean, if present driver will allow the user space >>> + to control the charging current and voltage through sysfs; >> >> This is not DT property. It does not describe hardware. > We needed a mechanism to enable the sysfs writes on certain properties. > If DT is not the place where should it go? DT is not the place. As I discussed later with Andreas, if you really need this and if mainline is a place for that then probably this should be compile option (a Kconfig symbol). I found one more issue after Andreas comments but I respond in that email. Best regards, Krzysztof