From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754194AbbIIXtc (ORCPT ); Wed, 9 Sep 2015 19:49:32 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:14094 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbbIIXt3 (ORCPT ); Wed, 9 Sep 2015 19:49:29 -0400 X-AuditID: cbfec7f5-f794b6d000001495-a6-55f0c5863697 Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger To: Andreas Dannenberg , laurentiu.palcu@intel.com References: <1441560187-23611-1-git-send-email-ramakrishna.pallala@intel.com> <20150909022617.GA32255@beast> <55EFB2C7.30800@samsung.com> <20150909173147.GA9887@beast> Cc: Ramakrishna Pallala , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Sebastian Reichel , Jenny TC From: Krzysztof Kozlowski Message-id: <55F0C586.3010003@samsung.com> Date: Thu, 10 Sep 2015 08:49:26 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <20150909173147.GA9887@beast> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t/xq7ptRz+EGhyYqW+x+soUdov5R86x Wqz92sNu8fqFocWVf8UWl3fNYbP43HuE0WLhm5tMFqd3lzhweize85LJY9OqTjaPvi2rGD2O 39jO5PF5k1wAaxSXTUpqTmZZapG+XQJXxpsNKgX3eSvW3p3M1sDYxt3FyMEhIWAi0fc8touR E8gUk7hwbz1bFyMXh5DAUkaJtfcPs0A4XxglDveuZQWpEhbwlzjZ/pwRxBYRcJVY8WYbO0TR J0aJ//tugrUzC1xhlOiZ9YAJpIpNwFhi8/IlbCA2r4CWxJtbl8AmsQioSux4eoodxBYViJA4 dfYtVI2gxI/J91hAbE6g+hu35zGBnMosoCdx/6IWSJhZQF5i85q3zBMYBWYh6ZiFUDULSdUC RuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCEB/3UH49JjVocYBTgYlXh4J7S8DxViTSwr rsw9xCjBwawkwpu2/UOoEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmkJ5akZqemFqQW wWSZODilGhgDl4t+N034O/0si8Dey+4qT9LeR1UumCyXmrxp2aTnWzpsZd7duLK41CSV/d5h iwpG0dMcUn0h33T5RL9K6dqsca4+c1Ap99EnEcFWCSv2PUyCSbunGT+OnZXUn83ecvN7xXtZ B/H/y/Zoe65dNS/7ee+xLfMdxY0P7z3ynsd3f/2tPYyL0zcrsRRnJBpqMRcVJwIA2NAGonQC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.09.2015 02:31, Andreas Dannenberg wrote: > On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: >> On 09.09.2015 11:26, Andreas Dannenberg wrote: >>> Krzysztof, good observation! In bq2425x_charger.c (formerly known as >>> bq24257_charger.c :) that I worked on the unit used was uA. At that time >>> I did a quick check and there didn't seem to be a clear standard whether >>> to use the "micro" or "milli" units - different drivers use different >>> units. However there seems to be a tendency for the TI drivers to prefer >>> "milli" (bq2415x_charger.c, bq24735-charger.c) >>> >>> Personally I think "milli" units are more appropriate for chargers since >>> they provide sufficient granularity and the numbers don't become too big >>> (try typing a voltage in the Volt-range in uV, it's very easy to get the >>> number of 0s wrong). However since the driver was already there I left >>> that aspect alone to preserve compatibility. >> >> I am fine with both units but milli indeed seems easier to judge by fast >> looking and less error-prone. Whatever you choose - choose the same one. :) > > Ok sounds good. If so, I could go ahead and change the units in the > bq2425x_charger.c over to mA and mV? Wait, these are existing bindings (for bq24257). You cannot change existing binding. Best regards, Krzysztof > It would be a bit labor some and I > also want to see what Laurentiu thinks but this way we could have most > of those TI charger drivers use the same units (the new bq24261 driver > Ram posted also uses mA/mV). Except bq25890_charger.c.... that would > still use uA/uV.... > > Laurentiu -- what made you chose the "micro" units for bq24257_charger.c > and bq25890_charger.c?