From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493AbbIJA1s (ORCPT ); Wed, 9 Sep 2015 20:27:48 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24709 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751829AbbIJA1q (ORCPT ); Wed, 9 Sep 2015 20:27:46 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-95-55f0ce7fa701 Subject: Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label To: Robert Baldyga , gregkh@linuxfoundation.org References: <1441705127-24125-1-git-send-email-r.baldyga@samsung.com> <1441705127-24125-3-git-send-email-r.baldyga@samsung.com> Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com From: Krzysztof Kozlowski Message-id: <55F0CE80.3030400@samsung.com> Date: Thu, 10 Sep 2015 09:27:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1441705127-24125-3-git-send-email-r.baldyga@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t/xK7r15z6EGqz7LWXRvHg9m8WUDR+Y LF6/MLS4vGsOm8WZxb3sFmuP3GW3eHB4J7sDu8f+uWvYPfq2rGL0WL/lKovH501yASxRXDYp qTmZZalF+nYJXBnb9n9hKzjGVXHtUy9TA+MMji5GDg4JAROJ41dyuxg5gUwxiQv31rN1MXJx CAksZZTYO3UbM4TzhVHi878r7CBVwgI+Ei9m9LOB2CICbhKL/t0Fs4UEGhklet/Kg9jMAtkS H5uXsYDYbALGEpuXLwGr4RXQkni8/RrYHBYBVYnOSafB4qICERKnzr6FqhGU+DH5HgvIcZxA 8zftdQcxmQX0JO5f1IKYLi+xec1b5gmMArOQNMxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc 4tK8dL3k/NxNjJCQ/rKDcfExq0OMAhyMSjy8E1rehwqxJpYVV+YeYpTgYFYS4U3b/iFUiDcl sbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYySW3RnZT3w0Pr1 yP3yrNL98zZ68Ge9qL4wrdBIznPhoiXG9/+sepXmZJFlffAYk63m3r2Pjy+p+HD1tWhxmrXD JpHdftv+PCs91i78+i///1m/DofcSIyVeZp0fpfg3HcLm2T2NE/e5mtsLZP6NufKjTyWFVNz Y9UF1h+KSjVndviw3nfJpubdSizFGYmGWsxFxYkAsxhcJ2UCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.09.2015 18:38, Robert Baldyga wrote: > This label does nothing special and we don't need to have it anymore. > > Signed-off-by: Robert Baldyga > --- > drivers/tty/serial/samsung.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Label does nothing but it has a meaning. It serves as a comment - ignore the character. So maybe: - goto ignore_char; + continue; /* Ignore character */ What do you think? Best regards, Krzysztof > > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > index fee764c..2b05194 100644 > --- a/drivers/tty/serial/samsung.c > +++ b/drivers/tty/serial/samsung.c > @@ -676,7 +676,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id) > dbg("break!\n"); > port->icount.brk++; > if (uart_handle_break(port)) > - goto ignore_char; > + continue; > } > > if (uerstat & S3C2410_UERSTAT_FRAME) > @@ -696,13 +696,10 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id) > } > > if (uart_handle_sysrq_char(port, ch)) > - goto ignore_char; > + continue; > > uart_insert_char(port, uerstat, S3C2410_UERSTAT_OVERRUN, > ch, flag); > - > -ignore_char: > - continue; > } > > spin_unlock_irqrestore(&port->lock, flags); >