From: Or Gerlitz <ogerlitz@mellanox.com>
To: Nicholas Krause <xerofoify@gmail.com>, <dledford@redhat.com>
Cc: <sean.hefty@intel.com>, <hal.rosenstock@gmail.com>,
<davem@davemloft.net>, <jackm@dev.mellanox.co.il>,
<roland@purestorage.com>, <monis@mellanox.com>,
<eranbe@mellanox.com>, <matanb@mellanox.com>,
<yishaih@mellanox.com>, <eugenia@mellanox.co.il>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header
Date: Thu, 10 Sep 2015 08:48:23 +0300 [thread overview]
Message-ID: <55F119A7.5060906@mellanox.com> (raw)
In-Reply-To: <1441839861-4342-1-git-send-email-xerofoify@gmail.com>
On 9/10/2015 2:04 AM, Nicholas Krause wrote:
> This fixes a incorrect assumation that ib_get_cached_pkey always runs
> successfully in the function build_mlx_header by checking if the calls
> to this particular function return the error code, -EINVAL in order to
> signal they failed to grap the public key for the device structure pointer
> passed to this function and if so return immediately to the caller of
> mlx_header with the error code -EINVAL to signal a error has occurred
> when calling this particular function that the caller must handle in
> its own intended error paths.
I am totally breathless, put 2-3 periods somewhere along this crazingly
long sentence.
Does this fixes some specific commit? if yes, please add Fixes: tag @
before your S.O.B linewith the offending commit short ID (--abbrev=12)
run speller (e.g assumation --> assumption), use IB/mlx4: prefix, add
space between the ":" to the 1st word of the title, e.g:
IB/mlx4: Fix assumption that ib_get_cached_pkey runs successfully in
build_mlx_header
Or.
parent reply other threads:[~2015-09-10 6:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1441839861-4342-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F119A7.5060906@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=eranbe@mellanox.com \
--cc=eugenia@mellanox.co.il \
--cc=hal.rosenstock@gmail.com \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=monis@mellanox.com \
--cc=roland@purestorage.com \
--cc=sean.hefty@intel.com \
--cc=xerofoify@gmail.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox