From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbbIJGWK (ORCPT ); Thu, 10 Sep 2015 02:22:10 -0400 Received: from mail-db3on0098.outbound.protection.outlook.com ([157.55.234.98]:23028 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751491AbbIJGWH (ORCPT ); Thu, 10 Sep 2015 02:22:07 -0400 X-Greylist: delayed 1072 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Sep 2015 02:22:06 EDT Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mellanox.com; Subject: Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header To: Nicholas Krause , References: <1441839861-4342-1-git-send-email-xerofoify@gmail.com> CC: , , , , , , , , , , , From: Or Gerlitz Message-ID: <55F119A7.5060906@mellanox.com> Date: Thu, 10 Sep 2015 08:48:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441839861-4342-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.223.0.75] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11OLC011;1:oTohA2iKp7gbuM+LyIKh5nYlfdRCx3GmwQfXU7SAYynVKOKd5gd8v6o9O6Y+ldRmt7/THQ0HiSYEZ6PHjNTYMXLchteJ8dLK0m228z11p5obaPrXsf85tbM0f9jqXZlqlFVdVniiow7uJKcU2RIq4scvQ9BsVyLRmvYnsCkxw3/6d2HduD0iPRtTRTWtEdM/CQpZyW08CH67t8i4NmTpSfzuT0+7/SFAoIFpL1OzymJ3dF/CFPDYox0SeF4hPWYT7GX02RavC3JVpAsyZBLnVAA0KS1GLeF3qwoo4mWJqjXMm/PY/y+ZzyNUz5X/uUmVFpC982z/EdOqX2lGI5vFv0ywgvBYjEXMp66cx+lA73BIeeGJdnwBXv9sej6wuX1opO5Q4Wil4aYZGNdQUMFrbw== X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(479174004)(24454002)(377454003)(77156002)(4001350100001)(92566002)(65816999)(5001830100001)(11100500001)(64126003)(106466001)(36756003)(47776003)(86362001)(59896002)(65806001)(68736005)(2950100001)(62966003)(23746002)(64706001)(65956001)(189998001)(5007970100001)(80316001)(5001860100001)(87266999)(33656002)(6806004)(5001770100001)(76176999)(50986999)(77096005)(4001540100001)(5004730100002)(87936001)(83506001)(97736004)(54356999)(50466002)(46102003)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR05MB348;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB348;2:xPESHOKkG081w8SFmar9DSVIYrW1sRHmAhh641MZ+ZvAs5AS8wKBuuetECCQg1M1PeQnUZdccY3AotqcU6upHSGKTH28GASajA1KoPWozziHaJzOdblCB6dn6v/S61RBwPRLCx8JOHirsXX1St9yHRTjqMxuu79DO57d5o68HUY=;3:eZ9oP/JDDHuqibIwj1w+3v/0n1ooTG2DGDgGMnOlUv0evSfZx+DzLhh+2cDGOOJjKxLwlR61R2IKVUuIWON7u4YOU5m+ZnZkA5JMfIn6eOCWXckJ6nGnlcxaOjyYB0kIHR5++w1ZOZJpkiubl35er0rfUWm6MpdZmlwKPvvbLWO/3yomrJDnGy4+izS08fN4iKPL7S41yVZ/dEmpZ6Zsq5s/hsqHQ2C1ROUEcgcOtiAmrw5HLeLTgTd2iyvzP6rSCeZ9sD3sib9wPJX+2231FQ==;25:nSZr6bY6NXWK+FyFNyUjlqFjL8J73mfdIK9Y2k9HUTZ/38I5Z1JzxbtZpoRmR41x0LpaGmH6/rJYlS2wqTbzKfOAV7zE6EDy31Cz62VAjWD4vJyjdlry2180ZT4Z/EuQQ3XtkhA00wn7JULYsf3Nk7JERzrbXGjbb8uoxNHt16Jz2hLLf4NQcSw6jHNUnaRUwfcTW3CnXDbBh6qP5ljhaoQEZhK03iqNkQWKAIxEH5VDHP7U1NU9wF7UkyATiGr1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB3PR05MB348; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB348;20:K37vrCJB3Vji0euOSrH67HzMMgXygLndoVPgDUAuFpwjC1jNgTlYmTTtj5TZ6BIT1bvElSFwC8AEj1veGNPJpM0K6qnstfUfy3aaI5ItGL9G/jrFkHc8QZuJUxyrWYGFUiLM/JPa2lOm+D+1Dpq/3ci1lIifoW9E6dw5crZcXI6db4hfzUuwthrymWF8BP9bTe27WcIkouNgD2LY8gxCE8ytpZfMH744FI5csraEDNfdlwo7hMXx2dx2p9+4cB4Ig4r18PZiPAgsdnXCvrPefi+H3WOWYCDLjXWUPMJuD7IXdgTIarddqRwLnDLiypZT0eVh3JWqTeXRDIWgpPdSlGxuPxxSWJKwzguaFRldJqssCTGWtmu2hpWHBPoU0aX/RDfaWvzIzr+oTU2uXk912TAlaMeS2aluodmg1pT7dsVM6Je/9d3zlr5Ms56kTojChyffYTn2VJlH/IFor8A18+6YBqVk83ARoku+VSyMFIq5F9ltJ2Poi3Fe3mOOa6ga;4:wcxBeS15g1wQlL25l2WxqpbpA1EUwnuRmf1/s11jhOVkiTt0SF1rV1ABgoyu5+gU6ac5cVGWd6HzyWflFEj+uDU/pI4Gu22WjcHjQP/Bhb/XcxWRIBBfcz6tlrZtrVSSkWWrecpOTtnw0uPznUy0ihW65Lgejgf1euYaE/nCwi8FshHrlRpAeYRaMmZSnZgjhjOFIK0u+m+d3FMk+rURUYCOV5ZihUMOyb9oln2jsOAI/8QXnfqeTq/YBs2YjNa0HLTnQgwcizDWpUE0pnifMYdnvGkEnQmRtEgkMvrsxlZhb0p3eedOLxUsxDinEkFg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:DB3PR05MB348;BCL:0;PCL:0;RULEID:;SRVR:DB3PR05MB348; X-Forefront-PRVS: 06952FC175 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB3PR05MB348;23:mob9VJVpSgnnM6ynpMJ5TKxronFhb7rEuBxK5c?= =?Windows-1252?Q?zeT4UoRyK2YhbER+1VFCjtmlJsivst1Pn7QDM28m+EVECGMF9oADf/gO?= =?Windows-1252?Q?AMdCdBmW7OwN/sW73Y6y3jLfoezel2cFINQ2fqnRratT176hkIPncIIP?= =?Windows-1252?Q?ZJCpByvAAAnkJX2oW55gTn775jJPo3kd8NXnGIs1kobCZH9dNOnt7raT?= =?Windows-1252?Q?OdqwTUByRHKfPSVzNpXj9qUV6d5II2umh4vLDmOqm8UmWUx1DICXenR4?= =?Windows-1252?Q?hL8kTrfD/fsmEVVHVtM14nIVN6J/FMN3Gv12ZDGG02AC2OFwkA/1fRGQ?= =?Windows-1252?Q?kws5/1eXAbncyjc7ni9oUg1ApQbjrV3I33Cny+SKQg/tlOkNsNl9LNUI?= =?Windows-1252?Q?eX/5vIcKEi88wMNXyaEjqRNi+a/x8CGjqmuFzhZG0S3/0HthgdSIN7CD?= =?Windows-1252?Q?96jQEaPwXdSIgKlRNTmKorcLJa5zAaPcJm/0HZFO17c9G6pdzr3UB/Hp?= =?Windows-1252?Q?mEgijCJ1yJm3KWi5lHBwun+YH7NnbyLc8JvNE7H/O7IvOS4gdtZIvnDQ?= =?Windows-1252?Q?YmIqs/ifl4InXuTdDmUJXExQTLInIcqyvr6PhCCy3IuHMdJ8jWqkVD1d?= =?Windows-1252?Q?Rsd8U+6fijZmb3ZGYUGHy3wr463O8I+VFodISunLvDoY24f9V5BOMKzd?= =?Windows-1252?Q?ElaGN2R0M53d0D59Llvs4wj3C1I5JtXZGSOAtPaqWlg49K6pQAxPoYtD?= =?Windows-1252?Q?Ctxxd8AQUFVMRBlV26YkXb2xTm9yx0v8CU45rmv70VJpq+nHao28cFDX?= =?Windows-1252?Q?WTiP9u7HolUCrpSJyXFs35wdY+nfdGt08wjrcUBZ3DBT7HkI8l1yXyTJ?= =?Windows-1252?Q?QzLCrPReJyF0BDPmg9jw+gkn0cxBO2o2SRwwyZkJhiKo4U3gK33z4QyN?= =?Windows-1252?Q?aWSBBbfX187e8icrr3VP6ZNcEDmsw766QHk/WGx5sJI9lUBnfUJ5R8SQ?= =?Windows-1252?Q?nAUJG/Qieifi7CHN4DmxJnJDUtGzDKy3TtETcxtmaQEu0LUdUqPrGfNn?= =?Windows-1252?Q?72iMlaC4ha9RasbxoX5DbLAyjnl6mFIywhywT7f8xgah3Uzyjfdn9ww9?= =?Windows-1252?Q?FiQEXja1eYVvzRgJ2tkucfQWzTw4sHVsFdq5d2Y/N0SnMsuYwTITJAJu?= =?Windows-1252?Q?KvLBxzaxlTJWhKvVgbfCGDw2m7J8doQBk0OhSwi7BogfCiPk/McFzPMl?= =?Windows-1252?Q?rakpJD+LVRJYZIFDVO3sbVmBSForhmLc/XPJDVZsoVXMPJ2BP7INydOO?= =?Windows-1252?Q?WsOj52NYE3teEJzekiTq5/Dl/ASHwiEfr+xkNphILm1jQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB348;5:QccZCIVrAss65DhueN2GiHN0gP2vqIi5EhkgeJ22Tf4baVuUprxRPmqUC+nTWPoBhwveTpENLZYbJY8XAEW0eTGeQdLgoIlVbr1v95Cz/VsGeVMeYx5yJbXic6HLItrjRP8sHK0oJDSpbIAuoEq7Hw==;24:+/j3xfRGBt6WPZuX5hp4iqdp03hMZ0e9OFBfOomzS/d1ytxX82DObjbLjV4mcxAs6ckitnuMyi2tYH/xxKyMmscMwGLcOJk6KdfUQOKBWMc=;20:08Oim54H5zGmjBIeas5o9UF+PkCYHRjO4f3QiMm2iX5PJOOwugrU0KSssvnFaGXSEmRCh8Q/o8t0YqLmkyydQw== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2015 05:48:49.5703 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR05MB348 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/2015 2:04 AM, Nicholas Krause wrote: > This fixes a incorrect assumation that ib_get_cached_pkey always runs > successfully in the function build_mlx_header by checking if the calls > to this particular function return the error code, -EINVAL in order to > signal they failed to grap the public key for the device structure pointer > passed to this function and if so return immediately to the caller of > mlx_header with the error code -EINVAL to signal a error has occurred > when calling this particular function that the caller must handle in > its own intended error paths. I am totally breathless, put 2-3 periods somewhere along this crazingly long sentence. Does this fixes some specific commit? if yes, please add Fixes: tag @ before your S.O.B linewith the offending commit short ID (--abbrev=12) run speller (e.g assumation --> assumption), use IB/mlx4: prefix, add space between the ":" to the 1st word of the title, e.g: IB/mlx4: Fix assumption that ib_get_cached_pkey runs successfully in build_mlx_header Or.