public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clocksource: Add CPU info to clocksource watchdog reporting
@ 2015-09-10  9:01 Seiichi Ikarashi
  2015-12-04 20:27 ` John Stultz
  0 siblings, 1 reply; 2+ messages in thread
From: Seiichi Ikarashi @ 2015-09-10  9:01 UTC (permalink / raw)
  To: John Stultz, Thomas Gleixner, linux-kernel

The clocksource watchdog reporting was improved by 0b046b217ad4c6.
I want to add the info of CPU where the watchdog detects a deviation
because it is necessary to identify the trouble spot if the clocksource is TSC.

Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>

---
 kernel/time/clocksource.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 174c594..db853e3 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -218,8 +218,8 @@ static void clocksource_watchdog(unsigned long data)
 
 		/* Check the deviation from the watchdog clocksource. */
 		if ((abs(cs_nsec - wd_nsec) > WATCHDOG_THRESHOLD)) {
-			pr_warn("timekeeping watchdog: Marking clocksource '%s' as unstable because the skew is too large:\n",
-				cs->name);
+			pr_warn("timekeeping watchdog on CPU%d: Marking clocksource '%s' as unstable because the skew is too large:\n",
+				smp_processor_id(), cs->name);
 			pr_warn("                      '%s' wd_now: %llx wd_last: %llx mask: %llx\n",
 				watchdog->name, wdnow, wdlast, watchdog->mask);
 			pr_warn("                      '%s' cs_now: %llx cs_last: %llx mask: %llx\n",

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clocksource: Add CPU info to clocksource watchdog reporting
  2015-09-10  9:01 [PATCH] clocksource: Add CPU info to clocksource watchdog reporting Seiichi Ikarashi
@ 2015-12-04 20:27 ` John Stultz
  0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2015-12-04 20:27 UTC (permalink / raw)
  To: Seiichi Ikarashi; +Cc: Thomas Gleixner, lkml

On Thu, Sep 10, 2015 at 2:01 AM, Seiichi Ikarashi
<s.ikarashi@jp.fujitsu.com> wrote:
> The clocksource watchdog reporting was improved by 0b046b217ad4c6.
> I want to add the info of CPU where the watchdog detects a deviation
> because it is necessary to identify the trouble spot if the clocksource is TSC.
>
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>

Sorry for the slow reply here, but I've queued this for 4.5

Thanks for sending it in!
-john

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-04 20:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-10  9:01 [PATCH] clocksource: Add CPU info to clocksource watchdog reporting Seiichi Ikarashi
2015-12-04 20:27 ` John Stultz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox