From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754600AbbIJKaZ (ORCPT ); Thu, 10 Sep 2015 06:30:25 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:35403 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbbIJKaW (ORCPT ); Thu, 10 Sep 2015 06:30:22 -0400 X-AuditID: cbfec7f5-f794b6d000001495-85-55f15bbce5ec Message-id: <55F15BBA.7090609@samsung.com> Date: Thu, 10 Sep 2015 12:30:18 +0200 From: Robert Baldyga User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Krzysztof Kozlowski , gregkh@linuxfoundation.org Cc: jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com Subject: Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label References: <1441705127-24125-1-git-send-email-r.baldyga@samsung.com> <1441705127-24125-3-git-send-email-r.baldyga@samsung.com> <55F0CE80.3030400@samsung.com> In-reply-to: <55F0CE80.3030400@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t/xy7p7oj+GGrQuEbNoXryezWLKhg9M Fq9fGFpc3jWHzeLM4l52i7VH7rI7sHnsn7uG3aNvyypGj/VbrrJ4fN4kF8ASxWWTkpqTWZZa pG+XwJXx7H1kwWmWikXzr7E1MJ5g7mLk5JAQMJE4+mApG4QtJnHh3nogm4tDSGApo8TJPT/Y IZxnjBJ3FzwC6+AV0JJY8q8NzGYRUJW4eGAiE4jNJqAjseX7BEYQW1QgQmL56pOMEPWCEj8m 32MBsUUEfCVuTrgLZjMLZEt8bF4GZgsL+Ei8mNEPtXkRo8TKGddYQRKcAtoSH+YtA7I5gBr0 JO5f1ILolZfYvOYt8wRGgVlIVsxCqJqFpGoBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxN jJBg/rqDcekxq0OMAhyMSjy8CRc/hAqxJpYVV+YeYpTgYFYS4U3bDhTiTUmsrEotyo8vKs1J LT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKYLBMHp1QDYztDwDZZ9+s7niQKvfLU3sgyN/DC cct9CpsX+C+7/3Dns+tTDy/Y//2b3ZpbP22lFukd3arn/anUq/TD1X+OB/zf61iedpLxMVnH apr4bM5pmZaFe7/uXRiQGaeQI+jorWBf1u91o3T/1dM7Dho7Wia/6vNu99M49r/87pZjGpOF NC7mP5/f9U6JpTgj0VCLuag4EQDFgiCKYgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2015 02:27 AM, Krzysztof Kozlowski wrote: > On 08.09.2015 18:38, Robert Baldyga wrote: >> This label does nothing special and we don't need to have it anymore. >> >> Signed-off-by: Robert Baldyga >> --- >> drivers/tty/serial/samsung.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) > > Label does nothing but it has a meaning. It serves as a comment - ignore > the character. So maybe: > > - goto ignore_char; > + continue; /* Ignore character */ > > What do you think? Look good to me. Thanks, Robert