From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: "Xie, Huawei" <huawei.xie@intel.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] vhost: move features to core
Date: Thu, 10 Sep 2015 22:15:05 +0300 [thread overview]
Message-ID: <55F1D6B9.3010007@cogentembedded.com> (raw)
In-Reply-To: <1441869802-15847-3-git-send-email-mst@redhat.com>
Hello.
On 09/10/2015 10:23 AM, Michael S. Tsirkin wrote:
> virtio 1 and any layout are core features, move them
> there. This fixes vhost test.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
[...]
> diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c
> index d9c501e..f2882ac 100644
> --- a/drivers/vhost/test.c
> +++ b/drivers/vhost/test.c
> @@ -277,10 +277,13 @@ static long vhost_test_ioctl(struct file *f, unsigned int ioctl,
> return -EFAULT;
> return 0;
> case VHOST_SET_FEATURES:
> + printk(KERN_ERR "1\n");
> if (copy_from_user(&features, featurep, sizeof features))
> return -EFAULT;
> + printk(KERN_ERR "2\n");
> if (features & ~VHOST_FEATURES)
> return -EOPNOTSUPP;
> + printk(KERN_ERR "3\n");
> return vhost_test_set_features(n, features);
> case VHOST_RESET_OWNER:
> return vhost_test_reset_owner(n);
Debugging printk's remained?
MBR, Sergei
next prev parent reply other threads:[~2015-09-10 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 7:23 [PATCH 0/4] vhost test fixes Michael S. Tsirkin
2015-09-10 7:23 ` [PATCH 1/4] tools/virtio: fix build after 4.2 changes Michael S. Tsirkin
2015-09-10 7:23 ` [PATCH 2/4] vhost: move features to core Michael S. Tsirkin
2015-09-10 19:15 ` Sergei Shtylyov [this message]
2015-09-10 7:23 ` [PATCH 3/4] tools/virtio: propagate V=X to kernel build Michael S. Tsirkin
2015-09-10 7:23 ` [PATCH 4/4] virtio: introduce avail cache Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F1D6B9.3010007@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=huawei.xie@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox