From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbbIJTPU (ORCPT ); Thu, 10 Sep 2015 15:15:20 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:33415 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753527AbbIJTPQ (ORCPT ); Thu, 10 Sep 2015 15:15:16 -0400 Subject: Re: [PATCH 2/4] vhost: move features to core To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <1441869802-15847-1-git-send-email-mst@redhat.com> <1441869802-15847-3-git-send-email-mst@redhat.com> Cc: "Xie, Huawei" , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55F1D6B9.3010007@cogentembedded.com> Date: Thu, 10 Sep 2015 22:15:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1441869802-15847-3-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 09/10/2015 10:23 AM, Michael S. Tsirkin wrote: > virtio 1 and any layout are core features, move them > there. This fixes vhost test. > > Signed-off-by: Michael S. Tsirkin [...] > diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c > index d9c501e..f2882ac 100644 > --- a/drivers/vhost/test.c > +++ b/drivers/vhost/test.c > @@ -277,10 +277,13 @@ static long vhost_test_ioctl(struct file *f, unsigned int ioctl, > return -EFAULT; > return 0; > case VHOST_SET_FEATURES: > + printk(KERN_ERR "1\n"); > if (copy_from_user(&features, featurep, sizeof features)) > return -EFAULT; > + printk(KERN_ERR "2\n"); > if (features & ~VHOST_FEATURES) > return -EOPNOTSUPP; > + printk(KERN_ERR "3\n"); > return vhost_test_set_features(n, features); > case VHOST_RESET_OWNER: > return vhost_test_reset_owner(n); Debugging printk's remained? MBR, Sergei