From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbbIKIJO (ORCPT ); Fri, 11 Sep 2015 04:09:14 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:35241 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbbIKIJG convert rfc822-to-8bit (ORCPT ); Fri, 11 Sep 2015 04:09:06 -0400 X-AuditID: cbfee68f-f793b6d000005f66-2a-55f28c20ed8f MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <55F28C20.2080800@samsung.com> Date: Fri, 11 Sep 2015 17:09:04 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , lee.jones@linaro.org Cc: myungjoo.ham@samsung.com, sameo@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack detection References: <1441885307-24499-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1441885307-24499-6-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: <1441885307-24499-6-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsWyRsSkUFeh51OowcQWPYt/U26wW8w/co7V 4v7Xo4wWl3fNYbO43biCzWL52/9sFqe7WR3YPe5c28PmMe9koMfLib/ZPPq2rGL0+LxJLoA1 issmJTUnsyy1SN8ugSvj6vzlTAXneSoeXZ7D1sC4kKuLkZNDQsBE4vDEy4wQtpjEhXvr2UBs IYEVjBIXTobC1Ly92MnUxcgFFJ/FKLGv5zxYEa+AoMSPyfdYQGxmAXWJSfMWMUPYIhLbvnQz QtjaEssWvmaGaH7AKHFv+WcWiGYtifWrW8CKWARUJdYvncwEYrMBxfe/uAG0gINDVCBCovtE JUhYRMBP4sPOuywgc5gFpjFK/Jt5kB0kISwQLfFqy0UWiAXzGSV+nTkMdh2nQJjE4jfbwM6W ELjGLtG/5iMrxDYBiW+TD7GAbJAQkJXYdIAZ4k1JiYMrbrBMYBSfheS5WUiem4XkuVlInlvA yLKKUTS1ILmgOCm9yFivODG3uDQvXS85P3cTIzBKT/971r+D8e4B60OMAhyMSjy8FqqfQoVY E8uKK3MPMZoCXTSRWUo0OR+YCvJK4g2NzYwsTE1MjY3MLc2UxHkXSv0MFhJITyxJzU5NLUgt ii8qzUktPsTIxMEp1cBot6Ax2sU+e4J33d/bn1xLpqy+yme3qWWu5OS3q4TFHu+W/izNbXXc et6WL4oucxVVMz9NV/NZwl24OCTMxqcjckW+Sylj/tt65i25OwOqAqO5hZ3W+vH9eresOvu9 t59xZ/7FU8rej03ZRQtN3/GYpAQ+Xr71d4GHstzi0/t+Cgm4fjzXd06JpTgj0VCLuag4EQAf 2r5FzQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jQV2Fnk+hBnPmaFr8m3KD3WL+kXOs Fve/HmW0uLxrDpvF7cYVbBbL3/5nszjdzerA7nHn2h42j3knAz1eTvzN5tG3ZRWjx+dNcgGs UQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAVygp lCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM+Y+u8pYsJenYsHT44wNjP1c XYycHBICJhJvL3YyQdhiEhfurWfrYuTiEBKYxSixr+c8G0iCV0BQ4sfkeyxdjBwczALyEkcu ZYOEmQXUJSbNW8QMUf+AUeLe8s8sEPVaEutXtzCC2CwCqhLrl04GW8AGFN//4gYbyBxRgQiJ 7hOVIGERAT+JDzvvsoDMYRaYxijxb+ZBdpCEsEC0xKstF1kgFsxnlPh15jDYQZwCYRKL32xj msAIdCbCfbMQ7puF5L4FjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYLj+pn0DsbD u9wPMQpwMCrx8FqofgoVYk0sK67MPcQowcGsJMJr2wEU4k1JrKxKLcqPLyrNSS0+xGgK9OBE ZinR5HxgyskriTc0NjEzsjQyN7QwMjZXEueVXfksVEggPbEkNTs1tSC1CKaPiYNTqoGRYabM pNCV5k8iAqPOfCvuFPDwn1BquPFA2OK5Zk1LBPizwnu66opl9nFui06J7n1ed+xm15GUT8cX Cu5MNtKu+/ShPu51cMguh1w53VUblqxz4xC3vThj762pN3eH7Qqsn88q9qZKWkc8r0px1sK+ Z5MtXy8PDb2h+Pznx0+znc2jZ/yx91qgxFKckWioxVxUnAgAjczjjQEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 09월 10일 20:41, Charles Keepax wrote: > Add additional bindings for both inverting the polarity of the jack > detection pins and allowing the use of a second jack detection pin. Note > that the second jack detection pin is hard wired in the chip so can only > be enabled through the binding, rather than a pin being specified. > > Signed-off-by: Charles Keepax > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index b98a11b..48bca6a 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -73,6 +73,12 @@ Optional properties: > If this node is not mentioned or if the value is unknown, then > headphone detection mode is set to HPDETL. > > + - wlf,use-jd-gpio : Use GPIO input alongwith JD1 for dual pin jack s/alongwith/along with > + detection. > + - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for > + jack detection. > + - wlf,jd-invert : Invert the polarity of the jack detection switch > + > - wlf,micd-software-compare : Use a software comparison to determine mic > presence > - wlf,micd-detect-debounce : Additional software microphone detection > If you fixes the minor typo, looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi