From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbbIKIMl (ORCPT ); Fri, 11 Sep 2015 04:12:41 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:53481 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbbIKIMf (ORCPT ); Fri, 11 Sep 2015 04:12:35 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79c56d000006efb-0f-55f28cf1756a Content-transfer-encoding: 8BIT Message-id: <55F28CF0.8020006@samsung.com> Date: Fri, 11 Sep 2015 17:12:32 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , lee.jones@linaro.org Cc: myungjoo.ham@samsung.com, sameo@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 1/6] mfd: arizona: Add TST_CAP bits for headphone detection References: <1441885307-24499-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: <1441885307-24499-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsWyRsSkQPdjz6dQg7PTOCz+TbnBbjH/yDlW i/tfjzJaXN41h83iduMKNovlb/+zWZzuZnVg97hzbQ+bx7yTgR4vJ/5m8+jbsorR4/MmuQDW KC6blNSczLLUIn27BK6Mr9fOsRTsEKvY8H41YwPjNsEuRk4OCQETiZXXJrBA2GISF+6tZ+ti 5OIQEljBKDHv63KgBAdYUccHW4j4UkaJRx2/mUEaeAUEJX5MvgdWwywgL3HkUjZImFlAXWLS vEXMEPUPGCV+rtrDClGvJbH4+hN2EJtFQFVicdtONhCbDSi+/8UNNpA5ogIREt0nKkHCIgJ+ Eh923mUBmcMsMI1R4t/Mg2C9wgL+Eh+37AWzhQRCJV5OnAw2h1MgTGJf5z9WkAYJgWvsEvff PGaBWCYg8W3yIahnZCU2HWCGeFhS4uCKGywTGMVmIXlnFsI7s5C8s4CReRWjaGpBckFxUnqR kV5xYm5xaV66XnJ+7iZGYLyd/vesbwfjzQPWhxgFOBiVeHgtVD+FCrEmlhVX5h5iNAU6YiKz lGhyPjCq80riDY3NjCxMTUyNjcwtzZTEeROkfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRq YJQ4tzmQd17Ht8DbKZzmy77O75A+zL1wc3pfzCnBL3Kp3C91zDZuS2k9vqTglrVd7Q2P+3G3 0xwy4o13FD3zmPFvDeuhvZOuCBY2vzde21L5MOLb+sWHYzJtHSeW/XnmfUdhn3zR1cArihOK ZQPtF8fPX7L++KfGU8sXfuz0PcS7fL3hO9spLSVKLMUZiYZazEXFiQDhC58ysgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsVy+t9jAd2PPZ9CDXZ+ZbL4N+UGu8X8I+dY Le5/PcpocXnXHDaL240r2CyWv/3PZnG6m9WB3ePOtT1sHvNOBnq8nPibzaNvyypGj8+b5AJY oxoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOArlBS KEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZny9do6lYIdYxYb3qxkbGLcJ djFycEgImEh0fLDtYuQEMsUkLtxbz9bFyMUhJLCUUeJRx29mkASvgKDEj8n3WEDqmQXkJY5c ygYJMwuoS0yat4gZov4Bo8TPVXtYIeq1JBZff8IOYrMIqEosbtvJBmKzAcX3v7jBBjJHVCBC ovtEJUhYRMBP4sPOuywgc5gFpjFK/Jt5EKxXWMBf4uOWvWC2kECoxMuJk8HmcAqESezr/Mc6 gVFgFpLzZiGcNwvJeQsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al6yXn525iBMf0M+kdjId3 uR9iFOBgVOLhtVD9FCrEmlhWXJl7iFGCg1lJhNe2AyjEm5JYWZValB9fVJqTWnyI0RTov4nM UqLJ+cB0k1cSb2hsYmZkaWRuaGFkbK4kziu78lmokEB6YklqdmpqQWoRTB8TB6dUA2NzukyE 4vzqTUu+LbLg4Vq37h0rc6bI0W/T0r6wbfJbdebFEzmxfxI25au0N+65vro6vnGb4pG5wRf6 fy1i47vYEtCq66K+tini2ecPxyZtSb6lkvj2J/P3xkZHh8vBeWy2p55zv1bacUHuu8T28tCm uC6xHzv6N0dt75BKXaXy6n+JS+wRsYtKLMUZiYZazEXFiQAU1c9T/wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, I recommend that you make the cover-letter patches on later. If you better to explain the patch description on cover-letter patch, we will understand what is this patch-set more easily. Thanks, Chanwoo Choi On 2015년 09월 10일 20:41, Charles Keepax wrote: > On Florida some additional settings are required to get accurate > measurements at the top end of the headphone detection range. This patch > adds the bits required for this. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/wm5110-tables.c | 2 ++ > include/linux/mfd/arizona/registers.h | 8 ++++++++ > 2 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c > index acb3bb2..78032e8 100644 > --- a/drivers/mfd/wm5110-tables.c > +++ b/drivers/mfd/wm5110-tables.c > @@ -1908,6 +1908,7 @@ static bool wm5110_readable_register(struct device *dev, unsigned int reg) > case ARIZONA_HP1_SHORT_CIRCUIT_CTRL: > case ARIZONA_HP2_SHORT_CIRCUIT_CTRL: > case ARIZONA_HP3_SHORT_CIRCUIT_CTRL: > + case ARIZONA_HP_TEST_CTRL_1: > case ARIZONA_AIF1_BCLK_CTRL: > case ARIZONA_AIF1_TX_PIN_CTRL: > case ARIZONA_AIF1_RX_PIN_CTRL: > @@ -2853,6 +2854,7 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg) > case ARIZONA_INPUT_ENABLES_STATUS: > case ARIZONA_OUTPUT_STATUS_1: > case ARIZONA_RAW_OUTPUT_STATUS_1: > + case ARIZONA_HP_TEST_CTRL_1: > case ARIZONA_SLIMBUS_RX_PORT_STATUS: > case ARIZONA_SLIMBUS_TX_PORT_STATUS: > case ARIZONA_INTERRUPT_STATUS_1: > diff --git a/include/linux/mfd/arizona/registers.h b/include/linux/mfd/arizona/registers.h > index e96644c..fe1b5d0 100644 > --- a/include/linux/mfd/arizona/registers.h > +++ b/include/linux/mfd/arizona/registers.h > @@ -237,6 +237,7 @@ > #define ARIZONA_HP1_SHORT_CIRCUIT_CTRL 0x4A0 > #define ARIZONA_HP2_SHORT_CIRCUIT_CTRL 0x4A1 > #define ARIZONA_HP3_SHORT_CIRCUIT_CTRL 0x4A2 > +#define ARIZONA_HP_TEST_CTRL_1 0x4A4 > #define ARIZONA_SPK_CTRL_2 0x4B5 > #define ARIZONA_SPK_CTRL_3 0x4B6 > #define ARIZONA_DAC_COMP_1 0x4DC > @@ -3548,6 +3549,13 @@ > #define ARIZONA_HP3_SC_ENA_WIDTH 1 /* HP3_SC_ENA */ > > /* > + * R1188 (0x4A4) HP Test Ctrl 1 > + */ > +#define ARIZONA_HP1_TST_CAP_SEL_MASK 0x0003 /* HP1_TST_CAP_SEL - [1:0] */ > +#define ARIZONA_HP1_TST_CAP_SEL_SHIFT 0 /* HP1_TST_CAP_SEL - [1:0] */ > +#define ARIZONA_HP1_TST_CAP_SEL_WIDTH 2 /* HP1_TST_CAP_SEL - [1:0] */ > + > +/* > * R1244 (0x4DC) - DAC comp 1 > */ > #define ARIZONA_OUT_COMP_COEFF_MASK 0xFFFF /* OUT_COMP_COEFF - [15:0] */ >