From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752286AbbIKIQ2 (ORCPT ); Fri, 11 Sep 2015 04:16:28 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:53939 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbbIKIQX (ORCPT ); Fri, 11 Sep 2015 04:16:23 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79106d00000728c-5f-55f28dd5face Content-transfer-encoding: 8BIT Message-id: <55F28DD4.3070303@samsung.com> Date: Fri, 11 Sep 2015 17:16:20 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , lee.jones@linaro.org Cc: myungjoo.ham@samsung.com, sameo@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 2/6] extcon: arizona: Additional settings to improve accuracy of HP detect References: <1441885307-24499-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1441885307-24499-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: <1441885307-24499-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsWyRsSkQPdq76dQg7bJXBb/ptxgt5h/5Byr xf2vRxktLu+aw2Zxu3EFm8Xyt//ZLE53szqwe9y5tofNY97JQI+XE3+zefRtWcXo8XmTXABr FJdNSmpOZllqkb5dAlfGw8M/mQsaBSq2/XrN3sB4naeLkZNDQsBEYvq5f4wQtpjEhXvr2boY uTiEBFYwSvS8uc0EU3Rx9mdWEFtIYBajxLcVqiA2r4CgxI/J91i6GDk4mAXkJY5cygYJMwuo S0yat4gZovwBo0THdR2QEl4BLYmFZ7VAwiwCqhIz188Dm84GFN7/4gYbSImoQIRE94lKkLCI gJ/Eh513WUCuYRaYxijxb+ZBdpCEsECCxJ9FH1ggzpzPKHFjy28WkASnQJjEhGvPwBISApfY JRrPXGSB2CYg8W3yIbA7JQRkJTYdYIZ4S1Li4IobLBMYxWYh+WYWwjezkHyzgJF5FaNoakFy QXFSepGhXnFibnFpXrpecn7uJkZgtJ3+96x3B+PtA9aHGAU4GJV4eC1UP4UKsSaWFVfmHmI0 BTpiIrOUaHI+MKbzSuINjc2MLExNTI2NzC3NlMR5FaV+BgsJpCeWpGanphakFsUXleakFh9i ZOLglGpgnBPlq/yi7cgbXo+CQG43hfdH1N+8EDja+kw5U6+uV4s55GdX4LeO+qx1tVLNW9ee FJrXXST/LPQ6z40TYiKGyy8mrflt431eroHd4aNeNJN2l9ECxgXsX+X9yqNrFoi5CN3+Ji2u +GJiiebBTRP21ZWUvw73brNaucYx49WOnc+4qqIfXJypxFKckWioxVxUnAgAmIT7G7ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t9jQd2rvZ9CDaZPZ7X4N+UGu8X8I+dY Le5/PcpocXnXHDaL240r2CyWv/3PZnG6m9WB3ePOtT1sHvNOBnq8nPibzaNvyypGj8+b5AJY oxoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOArlBS KEvMKQUKBSQWFyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZjw8/JO5oFGgYtuv1+wNjNd5 uhg5OSQETCQuzv7MCmGLSVy4t54NxBYSmMUo8W2FKojNKyAo8WPyPZYuRg4OZgF5iSOXskHC zALqEpPmLWKGKH/AKNFxXQekhFdAS2LhWS2QMIuAqsTM9fOYQGw2oPD+FzfYQEpEBSIkuk9U goRFBPwkPuy8CzScC2jiNEaJfzMPsoMkhAUSJP4s+gCWEBKYzyhxY8tvFpAEp0CYxIRrz1gm MALdiHDdLITrZiG5bgEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Ih+Jr2D8fAu 90OMAhyMSjy8FqqfQoVYE8uKK3MPMUpwMCuJ8Np2AIV4UxIrq1KL8uOLSnNSiw8xmgI9OJFZ SjQ5H5hs8kriDY1NzIwsjcwNLYyMzZXEeWVXPgsVEkhPLEnNTk0tSC2C6WPi4JRqYLTduHT7 RiavSv479/59mtL9r3WX607JI5/joplqjA5LS95atHF9q/LNbsWpH6UPrpQSuWLGtSbA0vCD /HOXnhWhZ5N5Nd6asGnFrlpc/UU2VXJZYRuDGU9uppThhIgGsTPbYh6dCgvOO56wrnn6nr6J RxTmGb3P87aLWhDiI5/VWlVi/Pn5eiWW4oxEQy3mouJEAP3r0F3+AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 09월 10일 20:41, Charles Keepax wrote: > If the TST_CAP_SEL bits aren't set correctly on wm5110/8280 there will > be a 100k load along side the headphones, which will affect the accurary > towards the very top of the detection range. This patch sets those bits. > > Signed-off-by: Charles Keepax > --- > drivers/extcon/extcon-arizona.c | 19 +++++++++++++++++-- > 1 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index b48fb29..7bfaacd 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -43,6 +43,9 @@ > #define ARIZONA_MICD_CLAMP_MODE_JDL_GP5H 0x9 > #define ARIZONA_MICD_CLAMP_MODE_JDH_GP5H 0xb > > +#define ARIZONA_TST_CAP_DEFAULT 0x3 > +#define ARIZONA_TST_CAP_CLAMP 0x1 > + > #define ARIZONA_HPDET_MAX 10000 > > #define HPDET_DEBOUNCE 500 > @@ -147,6 +150,7 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, > { > struct arizona *arizona = info->arizona; > unsigned int mask = 0, val = 0; > + unsigned int cap_sel = 0; > int ret; > > switch (arizona->type) { > @@ -154,10 +158,21 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, > case WM8280: > mask = ARIZONA_HP1L_SHRTO | ARIZONA_HP1L_FLWR | > ARIZONA_HP1L_SHRTI; > - if (clamp) > + if (clamp) { > val = ARIZONA_HP1L_SHRTO; > - else > + cap_sel = ARIZONA_TST_CAP_CLAMP; > + } else { > val = ARIZONA_HP1L_FLWR | ARIZONA_HP1L_SHRTI; > + cap_sel = ARIZONA_TST_CAP_DEFAULT; > + } > + > + ret = regmap_update_bits(arizona->regmap, > + ARIZONA_HP_TEST_CTRL_1, > + ARIZONA_HP1_TST_CAP_SEL_MASK, > + cap_sel); > + if (ret != 0) > + dev_warn(arizona->dev, > + "Failed to set TST_CAP_SEL: %d\n", ret); > break; > default: > mask = ARIZONA_RMV_SHRT_HP1L; > Acked-by: Chanwoo Choi Thanks, Chanwoo Choi