From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
Jason Wang <jasowang@redhat.com>
Cc: gleb@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic
Date: Fri, 11 Sep 2015 10:17:12 +0200 [thread overview]
Message-ID: <55F28E08.6060507@redhat.com> (raw)
In-Reply-To: <20150911093928.5cb7173c.cornelia.huck@de.ibm.com>
On 11/09/2015 09:39, Cornelia Huck wrote:
> > +static int
> > +kvm_deassign_ioeventfd_idx(struct kvm *kvm, enum kvm_bus bus_idx,
> > + struct kvm_ioeventfd *args)
>
> While this file uses newline before function name quite often, putting
> it on the same line seems more common - don't know which one the
> maintainers prefer.
I prefer it this way if it doesn't make the declaration one line longer,
which seems to be the case here.
Paolo
next prev parent reply other threads:[~2015-09-11 8:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 3:17 [PATCH V4 0/4] Fast MMIO eventfd fixes Jason Wang
2015-09-11 3:17 ` [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic Jason Wang
2015-09-11 7:39 ` Cornelia Huck
2015-09-11 8:17 ` Paolo Bonzini [this message]
2015-09-11 9:14 ` Jason Wang
2015-09-11 3:17 ` [PATCH V4 2/4] kvm: fix double free for fast mmio eventfd Jason Wang
2015-09-11 7:46 ` Cornelia Huck
2015-09-11 9:25 ` Jason Wang
2015-09-11 10:19 ` Cornelia Huck
2015-09-11 3:17 ` [PATCH V4 3/4] kvm: fix zero length mmio searching Jason Wang
2015-09-11 8:26 ` Paolo Bonzini
2015-09-11 8:31 ` Cornelia Huck
2015-09-11 9:26 ` Jason Wang
2015-09-11 3:17 ` [PATCH V4 4/4] kvm: add tracepoint for fast mmio Jason Wang
2015-09-11 8:15 ` [PATCH V4 0/4] Fast MMIO eventfd fixes Michael S. Tsirkin
2015-09-11 8:33 ` Paolo Bonzini
2015-09-11 9:28 ` Jason Wang
2015-09-13 8:51 ` Michael S. Tsirkin
2015-09-13 8:52 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F28E08.6060507@redhat.com \
--to=pbonzini@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox