From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299AbbIKIRS (ORCPT ); Fri, 11 Sep 2015 04:17:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbbIKIRP (ORCPT ); Fri, 11 Sep 2015 04:17:15 -0400 Subject: Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic To: Cornelia Huck , Jason Wang References: <1441941457-23630-1-git-send-email-jasowang@redhat.com> <1441941457-23630-2-git-send-email-jasowang@redhat.com> <20150911093928.5cb7173c.cornelia.huck@de.ibm.com> Cc: gleb@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com From: Paolo Bonzini Message-ID: <55F28E08.6060507@redhat.com> Date: Fri, 11 Sep 2015 10:17:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150911093928.5cb7173c.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2015 09:39, Cornelia Huck wrote: > > +static int > > +kvm_deassign_ioeventfd_idx(struct kvm *kvm, enum kvm_bus bus_idx, > > + struct kvm_ioeventfd *args) > > While this file uses newline before function name quite often, putting > it on the same line seems more common - don't know which one the > maintainers prefer. I prefer it this way if it doesn't make the declaration one line longer, which seems to be the case here. Paolo