From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbbIKJhd (ORCPT ); Fri, 11 Sep 2015 05:37:33 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:32676 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbbIKJhb (ORCPT ); Fri, 11 Sep 2015 05:37:31 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-72-55f2a0d822df Subject: Re: [PATCH 08/18] [media] s5c73m3: Export OF module alias information To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-9-git-send-email-javier@osg.samsung.com> <55F22C24.1070407@osg.samsung.com> Cc: Mauro Carvalho Chehab , Kyungmin Park , linux-media@vger.kernel.org From: Andrzej Hajda Message-id: <55F2A0D3.5080903@samsung.com> Date: Fri, 11 Sep 2015 11:37:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <55F22C24.1070407@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xy7o3FnwKNfi4V9jizds1TBZnm96w W1zeNYfNomfDVlaL1c8qHFg9tvTfZffo27KK0ePzJrkA5igum5TUnMyy1CJ9uwSujP6//1kL XvNXrLmxnamB8Q1PFyMnh4SAicSOyefZIWwxiQv31rN1MXJxCAksZZSY/e4NO4TznFHi2Ppj YFXCAn4S0w4uYwKxRQRCJf5dvM0IUbSMUeLPhH42kASzQK3Enb+TWUBsNgFNib+bb4LFeQW0 JH6uug82iEVAVeL79HnMILaoQITEqbNvoWoEJX5MvgfWyymgL7H78FkgmwNopp7E/YtaEOPl JTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kRErpfdjAu PmZ1iFGAg1GJh9dC9VOoEGtiWXFl7iFGCQ5mJRFe2w6gEG9KYmVValF+fFFpTmrxIUZpDhYl cd65u96HCAmkJ5akZqemFqQWwWSZODilGhiXsT3tVDYp8b9XNn3O7+hrlpd+5rok3oo1PF0h 5R3w76EE+8Ezto2zg2e3b3YQ3H1Cu0jcNcU64nu+SvnS8tebrAUFHF39X3W8O/+k+PaFCb1X 106feDLkwElxbc2+GRYrhaoW3r1fcmHl9tIPF5V1bGqYEm9GLYgomOzMOvGjx/55R5/Oi7RU YinOSDTUYi4qTgQAvKE+8VkCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2015 03:19 AM, Javier Martinez Canillas wrote: > Hello, > > On 08/20/2015 09:07 AM, Javier Martinez Canillas wrote: >> The SPI core always reports the MODALIAS uevent as "spi:" >> regardless of the mechanism that was used to register the device >> (i.e: OF or board code) and the table that is used later to match >> the driver with the device (i.e: SPI id table or OF match table). >> >> So drivers needs to export the SPI id table and this be built into >> the module or udev won't have the necessary information to autoload >> the needed driver module when the device is added. >> >> But this means that OF-only drivers needs to have both OF and SPI id >> tables that have to be kept in sync and also the dev node compatible >> manufacturer prefix is stripped when reporting the MODALIAS. Which can >> lead to issues if two vendors use the same SPI device name for example. >> >> To avoid the above, the SPI core behavior may be changed in the future >> to not require an SPI device table for OF-only drivers and report the >> OF module alias. So, it's better to also export the OF table even when >> is unused now to prevent breaking module loading when the core changes. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c >> index fa4a5ebda6b2..9983635ec253 100644 >> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c >> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c >> @@ -31,6 +31,7 @@ static const struct of_device_id s5c73m3_spi_ids[] = { >> { .compatible = "samsung,s5c73m3" }, >> { } >> }; >> +MODULE_DEVICE_TABLE(of, s5c73m3_spi_ids;); >> >> enum spi_direction { >> SPI_DIR_RX, >> > Any comments about this patch? > > Best regards, Ups, forgot about it. Reviewed-by: Andrzej Hajda Regards Andrzej