From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752601AbbIKKx0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Sep 2015 06:53:26 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:22740 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752509AbbIKKxW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Sep 2015 06:53:22 -0400
Message-ID: <55F2B28A.5020405@huawei.com>
Date: Fri, 11 Sep 2015 18:52:58 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Kan Liang <kan.liang@intel.com>
CC: Ingo Molnar <mingo@kernel.org>, <linux-kernel@vger.kernel.org>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>, Borislav Petkov <bp@suse.de>,
        David Ahern <dsahern@gmail.com>,
        "Frederic Weisbecker" <fweisbec@gmail.com>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 07/13] perf hists browser: Fixup the "cpu" column width
 calculation
References: <1441828225-667-1-git-send-email-acme@kernel.org> <1441828225-667-8-git-send-email-acme@kernel.org>
In-Reply-To: <1441828225-667-8-git-send-email-acme@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/9/10 3:50, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Since we were not setting it to at least 3 chars ('CPU'), it was being
> reset to zero when recalculating the columns width when refreshing the
> screen, in 'perf top'. Fix it.

Tested-by: Wang Nan <wangnan0@huawei.com>

> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Wang Nan <wangnan0@huawei.com>
> Link: http://lkml.kernel.org/n/tip-iqcdnkkqm6sew06x01fbijmy@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>   tools/perf/util/hist.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index 67b48616ab31..b3567a25f0c4 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -146,6 +146,7 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)
>   		hists__set_unres_dso_col_len(hists, HISTC_MEM_DADDR_DSO);
>   	}
>   
> +	hists__new_col_len(hists, HISTC_CPU, 3);
>   	hists__new_col_len(hists, HISTC_SOCKET, 6);
>   	hists__new_col_len(hists, HISTC_MEM_LOCKED, 6);
>   	hists__new_col_len(hists, HISTC_MEM_TLB, 22);